Skip to content

get method from transaction read function should accept Query type #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sushantdhiman opened this issue Jul 31, 2021 · 1 comment
Closed

Comments

@sushantdhiman
Copy link

This concern was earlier raised in #6, but was lost in discussion.

For Node.js SDK
Transaction support reading multiple documents using get by passing Query.

https://github.com/googleapis/nodejs-firestore/blob/f5bec38de92479ca7930178089843e77411ead3d/types/firestore.d.ts#L450-L457

For Firestore JS SDK
I don't think this is supported for Web version.

https://firebase.google.com/docs/reference/js/firebase.firestore.Transaction#get

Current v8 implementation for this library still only supports getting single reference in transaction read function. get should accept Query as well, so it can read multiple documents and acquire pessimistic lock on them.

@kossnocorp
Copy link
Owner

Fixed with v10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants