Skip to content
This repository was archived by the owner on Jan 25, 2020. It is now read-only.

lack of "cookie-parser" dependency info #13

Open
mszmida opened this issue Nov 15, 2017 · 0 comments
Open

lack of "cookie-parser" dependency info #13

mszmida opened this issue Nov 15, 2017 · 0 comments

Comments

@mszmida
Copy link

mszmida commented Nov 15, 2017

In Readme.md file there is no information that this package relies on cookie-parser express middleware existence. Consider reading and writing cookies directly by your package.

There is also no information that JWT token is returned and cookie is being set on GET request automagically by middleware. It is important information in use case of your package with RESTfull API.

The last thing:
(node:2281) Warning: Use Cipheriv for counter mode of aes-256-ctr

Cipher algorithm should be updated, read here.

Thank you for your work :-)

@mszmida mszmida changed the title cookie-parser dependency info lack of "cookie-parser" dependency info Nov 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant