Skip to content

Commit eb12212

Browse files
YujiOshimak8s-ci-robot
authored andcommittedOct 17, 2018
fix manifest examples (#213)
* fix manifest examples Signed-off-by: YujiOshima <[email protected]> * fix MetricsCollector instance Signed-off-by: YujiOshima <[email protected]>
1 parent 7ad8cfc commit eb12212

File tree

5 files changed

+16
-16
lines changed

5 files changed

+16
-16
lines changed
 

‎examples/random-example.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ spec:
3838
apiVersion: batch/v1
3939
kind: Job
4040
metadata:
41-
name: {{.WorkerId}}
41+
name: {{.WorkerID}}
4242
namespace: katib
4343
spec:
4444
template:
4545
spec:
4646
containers:
47-
- name: {{.WorkerId}}
47+
- name: {{.WorkerID}}
4848
image: katib/mxnet-mnist-example
4949
command:
5050
- "python"

‎examples/workerConfigMap.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ data:
88
apiVersion: batch/v1
99
kind: Job
1010
metadata:
11-
name: {{.WorkerId}}
11+
name: {{.WorkerID}}
1212
namespace: katib
1313
spec:
1414
template:
1515
spec:
1616
containers:
17-
- name: {{.WorkerId}}
17+
- name: {{.WorkerID}}
1818
image: katib/mxnet-mnist-example
1919
command:
2020
- "python"
@@ -30,13 +30,13 @@ data:
3030
apiVersion: batch/v1
3131
kind: Job
3232
metadata:
33-
name: {{.WorkerId}}
33+
name: {{.WorkerID}}
3434
namespace: katib
3535
spec:
3636
template:
3737
spec:
3838
containers:
39-
- name: {{.WorkerId}}
39+
- name: {{.WorkerID}}
4040
image: katib/mxnet-mnist-example:gpu
4141
command:
4242
- "python"

‎manifests/studyjobcontroller/metricsControllerConfigMap.yaml

+5-5
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ data:
88
apiVersion: batch/v1beta1
99
kind: CronJob
1010
metadata:
11-
name: {{.WorkerId}}
11+
name: {{.WorkerID}}
1212
namespace: katib
1313
spec:
1414
schedule: "*/1 * * * *"
@@ -20,16 +20,16 @@ data:
2020
spec:
2121
serviceAccountName: metrics-collector
2222
containers:
23-
- name: {{.WorkerId}}
23+
- name: {{.WorkerID}}
2424
image: katib/metrics-collector
2525
args:
2626
- "./metricscollector"
2727
- "-s"
28-
- "{{.StudyId}}"
28+
- "{{.StudyID}}"
2929
- "-t"
30-
- "{{.TrialId}}"
30+
- "{{.TrialID}}"
3131
- "-w"
32-
- "{{.WorkerId}}"
32+
- "{{.WorkerID}}"
3333
- "-n"
3434
- "{{.NameSpace}}"
3535
restartPolicy: Never

‎manifests/studyjobcontroller/workerConfigMap.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ data:
88
apiVersion: batch/v1
99
kind: Job
1010
metadata:
11-
name: {{.WorkerId}}
11+
name: {{.WorkerID}}
1212
namespace: katib
1313
spec:
1414
template:
1515
spec:
1616
containers:
17-
- name: {{.WorkerId}}
17+
- name: {{.WorkerID}}
1818
image: alpine
1919
restartPolicy: Never

‎pkg/controller/studyjobcontroller/studyjob_controller.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -874,9 +874,9 @@ func (r *ReconcileStudyJobController) getMetricsCollectorManifest(studyID string
874874
var mtp *template.Template = nil
875875
var err error
876876
tmpValues := map[string]string{
877-
"StudyId": studyID,
878-
"TrialId": trialID,
879-
"WorkerId": workerID,
877+
"StudyID": studyID,
878+
"TrialID": trialID,
879+
"WorkerID": workerID,
880880
"NameSpace": namespace,
881881
}
882882
if mcs != nil {

0 commit comments

Comments
 (0)
Please sign in to comment.