Skip to content

Implement TrainingRuntimes finalizer mechanism #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
tenzen-y opened this issue Apr 21, 2025 · 2 comments
Open
2 tasks

Implement TrainingRuntimes finalizer mechanism #2609

tenzen-y opened this issue Apr 21, 2025 · 2 comments
Assignees

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Apr 21, 2025

What you would like to be added?

We would like to implement the Finalizer trainer.kubeflow.org/resource-in-use mechanism against TrainingRuntime and ClusterTrainingRuntime.

Why is this needed?

The Finalizer prevents accidentally removing the TrainingRuntime when the referenced TrainJob has already been created.
If we do not have such a mechanism, the TrainingRuntime will be accidentally removed, and TrainJob will be disrupted since the actual Jobs (JobSet) will be built by TrainingRuntime and TrainJob.

Love this feature?

Give it a 👍 We prioritize the features with most 👍

@tenzen-y
Copy link
Member Author

/assign

@tenzen-y
Copy link
Member Author

/remove-label lifecycle/needs-triage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant