Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d04e5a6df45f87cba3b945c5f3a536b0cae0f5e7
Choose a base ref
..
head repository: kubernetes-sigs/controller-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ffdccf56a5fc4c3228310ebe2f410749fb481254
Choose a head ref
Showing with 1 addition and 1 deletion.
  1. +1 −1 pkg/cache/internal/cache_reader.go
2 changes: 1 addition & 1 deletion pkg/cache/internal/cache_reader.go
View file
Original file line number Diff line number Diff line change
@@ -161,7 +161,7 @@ func (c *CacheReader) List(_ context.Context, out client.ObjectList, opts ...cli
}

var outObj runtime.Object
if c.disableDeepCopy || *listOpts.UnsafeDisableDeepCopy {
if c.disableDeepCopy || (listOpts.UnsafeDisableDeepCopy != nil && *listOpts.UnsafeDisableDeepCopy) {
// skip deep copy which might be unsafe
// you must DeepCopy any object before mutating it outside
outObj = obj