Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

big size node memory cause metrics overflow #2541

Closed
leiwingqueen opened this issue Nov 1, 2024 · 2 comments
Closed

big size node memory cause metrics overflow #2541

leiwingqueen opened this issue Nov 1, 2024 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@leiwingqueen
Copy link
Contributor

What happened:

I have a machine with big memory (about 10000TB size) will get a negative number in metrics. I found that the node metrics value do the convert as float64(val.MilliValue()) / 1000 before return. It may overflow when the value is bigger than maxInt64/1000.

What you expected to happen:

KSM will return the correct number even when the value is bigger than maxInt64/1000

How to reproduce it (as minimally and precisely as possible):

node memory size is larger than maxInt64/1000

Anything else we need to know?:

Environment:

  • kube-state-metrics version:
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • Other info:
@leiwingqueen leiwingqueen added the kind/bug Categorizes issue or PR as related to a bug. label Nov 1, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 1, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@CatherineF-dev
Copy link
Contributor

/close #2540

@mrueg mrueg closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

4 participants