Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rbac after controller-runtime update #19906

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Fix rbac after controller-runtime update #19906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions config/prow/cluster/prow_controller_manager_rbac.yaml
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -24,6 +24,21 @@ metadata:
namespace: default namespace: default
name: "prow-controller-manager" name: "prow-controller-manager"
rules: rules:
- apiGroups:
- coordination.k8s.io
resources:
- leases
resourceNames:
- prow-controller-manager-leader-lock
verbs:
- get
- update
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- create
- apiGroups: - apiGroups:
- "" - ""
resources: resources:
Expand Down
15 changes: 15 additions & 0 deletions config/prow/cluster/sinker_rbac.yaml
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -19,6 +19,21 @@ rules:
- list - list
- watch - watch
- get - get
- apiGroups:
- coordination.k8s.io
resources:
- leases
resourceNames:
- prow-sinker-leaderlock
verbs:
- get
- update
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- create
- apiGroups: - apiGroups:
- "" - ""
resources: resources:
Expand Down
30 changes: 30 additions & 0 deletions config/prow/cluster/starter-gcs.yaml
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -749,6 +749,21 @@ rules:
- list - list
- watch - watch
- get - get
- apiGroups:
- coordination.k8s.io
resources:
- leases
resourceNames:
- prow-sinker-leaderlock
verbs:
- get
- update
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- create
- apiGroups: - apiGroups:
- "" - ""
resources: resources:
Expand Down Expand Up @@ -1056,6 +1071,21 @@ rules:
- watch - watch
- update - update
- patch - patch
- apiGroups:
- coordination.k8s.io
resources:
- leases
resourceNames:
- prow-controller-manager-leader-lock
verbs:
- get
- update
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- create
- apiGroups: - apiGroups:
- "" - ""
resources: resources:
Expand Down
30 changes: 30 additions & 0 deletions config/prow/cluster/starter-s3.yaml
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -746,6 +746,21 @@ rules:
- list - list
- watch - watch
- get - get
- apiGroups:
- coordination.k8s.io
resources:
- leases
resourceNames:
- prow-sinker-leaderlock
verbs:
- get
- update
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- create
- apiGroups: - apiGroups:
- "" - ""
resources: resources:
Expand Down Expand Up @@ -1053,6 +1068,21 @@ rules:
- watch - watch
- update - update
- patch - patch
- apiGroups:
- coordination.k8s.io
resources:
- leases
resourceNames:
- prow-controller-manager-leader-lock
verbs:
- get
- update
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- create
- apiGroups: - apiGroups:
- "" - ""
resources: resources:
Expand Down
2 changes: 2 additions & 0 deletions prow/ANNOUNCEMENTS.md
View file
Open in desktop
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -127,7 +127,9 @@ Note: versions specified in these announcements may not include bug fixes made
in more recent versions so it is recommended that the most recent versions are in more recent versions so it is recommended that the most recent versions are
used when updating deployments. used when updating deployments.


- *November 11th, 2020* The prow-controller-manager and sinker now require RBAC to be set up to manage their leader lock in the `coordination.k8s.io` group. See [here](https://github.com/kubernetes/test-infra/pull/19906/files?diff=split&w=1)
- *November, 2020* The deprecated `namespace` and `additional_namespaces` properties have been removed from the config updater plugin - *November, 2020* The deprecated `namespace` and `additional_namespaces` properties have been removed from the config updater plugin
for more details.
- *November, 2020* The `blacklist` flag in status reconciler has been deprecated in favor of `denylist`. The support of `blacklist` will be stopped in February 2021. - *November, 2020* The `blacklist` flag in status reconciler has been deprecated in favor of `denylist`. The support of `blacklist` will be stopped in February 2021.
- *October, 2020* The `plank` binary has been deprecated in favor of the more modern implementation in the prow-controller-manager that provides the same functionality. Check out - *October, 2020* The `plank` binary has been deprecated in favor of the more modern implementation in the prow-controller-manager that provides the same functionality. Check out
its [README](/prow//prow-controller-manager/README.md) or check out its [deployment](config/prow/cluster/prow_controller_manager_deployment.yaml) and its [README](/prow//prow-controller-manager/README.md) or check out its [deployment](config/prow/cluster/prow_controller_manager_deployment.yaml) and
Expand Down