Add query methods for Statement which take ownership #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I apologize that I have not replied so long. I have thought about it one or two hours per week. Could you change as follows?
|
This is in the same spirit as `Connection::query()`, which also takes ownership of the statement it used. An actual use case of this can be wanting to store the ResultSet in a struct for later usage, while at the same time having the ability to use StatementBuilder to set parameters. Signed-off-by: Christoph Heiss <[email protected]>
|
I just pushed a new version with your suggestions incorporated. Thanks for looking into it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
basically as the title and commit message says.
It mimics the interface of
Connection::query_*(), which take ownership of the statement instead of borrowing it.I hope the method names are okay, but I'll happily rename them if there are any better suggestions.
This can be used if
StatementBuilderneeds to be used, without having to store bothStatementand theResultSetin a struct together (which is quite painful in Rust to do).Thanks!