Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make errors usable across threads #6

Merged
merged 1 commit into from
Sep 29, 2018
Merged

Conversation

rkarp
Copy link
Contributor

@rkarp rkarp commented Sep 28, 2018

Will also allow the blanket impl for the Fail trait of the failure crate to work.

@kubo kubo merged commit c600481 into kubo:master Sep 29, 2018
@kubo
Copy link
Owner

kubo commented Sep 29, 2018

@rkarp Thank you! I'll release rust-oracle 0.2.0 after some other breaking changes are added.

kubo added a commit that referenced this pull request Sep 29, 2018
@rkarp rkarp deleted the fix-err-type branch September 29, 2018 12:47
@rkarp
Copy link
Contributor Author

rkarp commented Sep 29, 2018

@kubo BTW, I don't believe this is a breaking change since it just implicitly lets oracle::Error implement Send + Sync.

Edit: Well, except if someone explicitly requires his errors to be !Send or !Sync which seems extremely unlikely.

@kubo
Copy link
Owner

kubo commented Sep 29, 2018

It introduced additional restriction to the argument of oracle::Error::ParseError.
If someone writes oracle::Error::ParseError(Box::new(err)) and the err doesn't implement Send + Sync, it cannot be compiled. So I consider it is a breaking change even though I believe that nobody writes such code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants