Error handling when requesting to package registry

Author: kyoshidajp

cmd/bundler.go

@@ -13,9 +13,7 @@ type BundlerDoctor struct {
 }
 
 func NewBundlerDoctor() *BundlerDoctor {
-	t := http.DefaultTransport.(*http.Transport).Clone()
-	t.MaxIdleConnsPerHost = -1
-	client := &http.Client{Transport: t}
+	client := &http.Client{}
 	return &BundlerDoctor{HTTPClient: *client}
 }
 

cmd/nodejs.go

@@ -2,6 +2,7 @@ package cmd
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -22,13 +23,26 @@ type Nodejs struct {
 
 func (n *Nodejs) fetchURLFromRegistry(client http.Client) (string, error) {
 	url := fmt.Sprintf(NODEJS_REGISTRY_API, n.name)
-	req, _ := http.NewRequest(http.MethodGet, url, nil)
-	resp, _ := client.Do(req)
-	body, _ := io.ReadAll(resp.Body)
+	req, err := http.NewRequest(http.MethodGet, url, nil)
+	if err != nil {
+		return "", err
+	}
+
+	resp, err := client.Do(req)
+	if err != nil {
+		return "", nil
+	}
+
 	defer resp.Body.Close()
+	if resp.StatusCode < 200 || 299 < resp.StatusCode {
+		m := fmt.Sprintf("Got status code: %d from %s", resp.StatusCode, RUBY_GEMS_REGISTRY_API)
+		return "", errors.New(m)
+	}
+
+	body, _ := io.ReadAll(resp.Body)
 
 	var NodejsRegistryResponse NodejsRegistryResponse
-	err := json.Unmarshal(body, &NodejsRegistryResponse)
+	err = json.Unmarshal(body, &NodejsRegistryResponse)
 	if err != nil {
 		return "", nil
 	}

cmd/pypi.go

@@ -2,6 +2,7 @@ package cmd
 
 import (
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -25,13 +26,26 @@ type Pypi struct {
 
 func (p *Pypi) fetchURLFromRepository(client http.Client) (string, error) {
 	url := fmt.Sprintf(PYPI_REGISTRY_API, p.name)
-	req, _ := http.NewRequest(http.MethodGet, url, nil)
-	resp, _ := client.Do(req)
-	body, _ := io.ReadAll(resp.Body)
+	req, err := http.NewRequest(http.MethodGet, url, nil)
+	if err != nil {
+		return "", err
+	}
+
+	resp, err := client.Do(req)
+	if err != nil {
+		return "", err
+	}
+
 	defer resp.Body.Close()
+	if resp.StatusCode < 200 || 299 < resp.StatusCode {
+		m := fmt.Sprintf("Got status code: %d from %s", resp.StatusCode, RUBY_GEMS_REGISTRY_API)
+		return "", errors.New(m)
+	}
+
+	body, _ := io.ReadAll(resp.Body)
 
 	var PypiRegistryResponse PypiRegistryResponse
-	err := json.Unmarshal(body, &PypiRegistryResponse)
+	err = json.Unmarshal(body, &PypiRegistryResponse)
 	if err != nil {
 		return "", nil
 	}

cmd/ruby_gems.go

@@ -23,15 +23,28 @@ type RubyGems struct {
 
 func (g *RubyGems) fetchURLFromRegistry(client http.Client) (string, error) {
 	url := fmt.Sprintf(RUBY_GEMS_REGISTRY_API, g.name)
-	req, _ := http.NewRequest(http.MethodGet, url, nil)
-	resp, _ := client.Do(req)
-	body, _ := io.ReadAll(resp.Body)
+	req, err := http.NewRequest(http.MethodGet, url, nil)
+	if err != nil {
+		return "", err
+	}
+
+	resp, err := client.Do(req)
+	if err != nil {
+		return "", err
+	}
+
 	defer resp.Body.Close()
+	if resp.StatusCode < 200 || 299 < resp.StatusCode {
+		m := fmt.Sprintf("Got status code: %d from %s", resp.StatusCode, RUBY_GEMS_REGISTRY_API)
+		return "", errors.New(m)
+	}
+
+	body, _ := io.ReadAll(resp.Body)
 
 	var Gem RubyGemsRegistryResponse
-	err := json.Unmarshal(body, &Gem)
+	err = json.Unmarshal(body, &Gem)
 	if err != nil {
-		return "", errors.New("error: Unknown response")
+		return "", err
 	}
 
 	if Gem.SourceCodeUri != "" {