Shows messages in GUI; Fixes puphpet#1511

Author: jtreminio

src/Puphpet/MainBundle/Controller/FrontController.php

@@ -8,6 +8,7 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpFoundation\Session\Session;
 use Symfony\Component\Yaml\Yaml;
 
 class FrontController extends Controller
@@ -16,6 +17,9 @@ public function indexAction(Request $request)
     {
         $manager = $this->get('puphpet.extension.manager');
 
+        /** @var Session $session */
+        $session = $this->get('session');
+
         if ($request->isMethod('POST')) {
             $archive = $manager->createArchive($request->request->all());
 
@@ -27,44 +31,74 @@ public function indexAction(Request $request)
             return $response;
         }
 
+        $messages = $session->getFlashBag()->all();
+
         return $this->render('PuphpetMainBundle:front:template.html.twig', [
             'extensions' => $manager->getExtensions(),
+            'messages'   => $messages,
         ]);
     }
 
     public function uploadConfigAction(Request $request)
     {
         $config = $this->normalizeLineBreaks($request->get('config'));
 
+        /** @var Session $session */
+        $session = $this->get('session');
+
         try {
             $yaml = Yaml::parse($config);
-        } catch (\Exception $e) {}
+        } catch (\Exception $e) {
+            $session->getFlashBag()->add('error', [
+                'title'   => 'There was a problem parsing your config file',
+                'content' => $e->getMessage(),
+            ]);
+
+            $request->setMethod('GET');
+
+            return $this->indexAction($request);
+        }
 
         if (empty($yaml)) {
-            $this->get('session')->getFlashBag()->add(
-                'error',
-                'The config file provided was empty! Please recreate your manifest manually below.'
-            );
+            $session->getFlashBag()->add('error', [
+                'title'   => 'The config file provided was empty',
+                'content' => 'Check your config file, or manually recreate it in the GUI.',
+            ]);
 
-            return new RedirectResponse($this->generateUrl('puphpet.main.homepage'));
+            $request->setMethod('GET');
+
+            return $this->indexAction($request);
         }
 
         $manager = $this->get('puphpet.extension.manager');
         $manager->setCustomDataAll($yaml);
 
         try {
+            $session->getFlashBag()->add('success', [
+                'title'   => 'Success!',
+                'content' => 'Your previously generated config file was successfully loaded!',
+            ]);
+
             $rendered = $this->render('PuphpetMainBundle:front:template.html.twig', [
                 'extensions' => $manager->getExtensions(),
+                'messages'   => $session->getFlashBag()->all(),
             ]);
 
             return $rendered;
         } catch (\Exception $e) {
-            $this->get('session')->getFlashBag()->add(
-                'error',
-                'The config file provided had errors! Please recreate your manifest manually below.'
-            );
+            $session->getFlashBag()->clear();
+
+            $session->getFlashBag()->add('error', [
+                'title'   => 'There was a problem parsing your config file',
+                'content' => sprintf(
+                    '<p> Please recreate your manifest manually below.</p>' .
+                    '<p>Error message:</p><p>%s</p>', $e->getMessage()
+                )
+            ]);
+
+            $request->setMethod('GET');
 
-            return new RedirectResponse($this->generateUrl('puphpet.main.homepage'));
+            return $this->indexAction($request);
         }
     }
 

src/Puphpet/MainBundle/Resources/views/front/alerts.html.twig

@@ -13,6 +13,7 @@
             <link rel="stylesheet" href="{{ asset('assets/v5/vendor/bootstrap-3.3.4/bootstrap-3.3.4.css') }}" />
             <link rel="stylesheet" href="{{ asset('assets/v5/vendor/selectize.js/selectize.bootstrap3.css') }}" />
             <link rel="stylesheet" href="{{ asset('assets/v5/vendor/webui-popover/jquery.webui-popover.css') }}" />
+            <link rel="stylesheet" href="{{ asset('assets/v5/vendor/pnotify/pnotify.custom.min.css') }}" />
             <link rel="stylesheet" href="{{ asset('assets/v5/css/style.css') }}" />
         {% endblock %}
 
@@ -28,6 +29,15 @@
 {% endblock head %}
 
 <body>
+
+{% for messageType, innerMessages in messages %}
+    {% for messageIndex, message in innerMessages %}
+        <div class="growl-alert" data-title="{{ message.title }}" data-type="{{ messageType }}">
+            {{ message.content }}
+        </div>
+    {% endfor %}
+{% endfor %}
+
 <section id="container">
 
 {% block topMenu %}
@@ -130,6 +140,7 @@
         <script>hljs.initHighlightingOnLoad();</script>
         <script src="{{ asset('assets/v5/vendor/selectize.js/selectize.min.js') }}"></script>
         <script src="{{ asset('assets/v5/vendor/webui-popover/jquery.webui-popover.js') }}"></script>
+        <script src="{{ asset('assets/v5/vendor/pnotify/pnotify.custom.min.js') }}"></script>
         <script src="{{ asset('assets/v5/js/custom.js') }}"></script>
     {% endblock footerJs %}
 

src/Puphpet/MainBundle/Resources/views/front/template.html.twig

@@ -721,6 +721,10 @@ legend {
     padding: 10px;
 }
 
+.growl-alert {
+    display: none;
+}
+
 @media (min-width: 768px) {
     .modal-dialog {
         margin: 75px auto;

web/assets/v5/css/style.css

@@ -802,6 +802,16 @@ PUPHPET.disableEnterSubmit = function() {
     });
 };
 
+PUPHPET.bootstrapNotify = function() {
+    $('.growl-alert').each(function() {
+        new PNotify({
+            title: this.getAttribute('data-title'),
+            text: $(this).html(),
+            type: this.getAttribute('data-type')
+        });
+    });
+};
+
 $(document).ready(function() {
     PUPHPET.updateOtherInput();
     PUPHPET.updateOtherInputSelect();
@@ -820,6 +830,7 @@ $(document).ready(function() {
     PUPHPET.toggleDisplayOnSelect();
     PUPHPET.uploadConfig();
     PUPHPET.disableEnterSubmit();
+    PUPHPET.bootstrapNotify();
 });
 
 /**