Skip to content

Commit 9a24470

Browse files
committed
Remove calls to ReflectionProperty::setAccessible now it is no longer necessary
Signed-off-by: George Steel <[email protected]>
1 parent 914cee1 commit 9a24470

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

src/Test/EventListenerIntrospectionTrait.php

+2-4
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ trait EventListenerIntrospectionTrait
3939
*/
4040
private function getEventsFromEventManager(EventManager $events)
4141
{
42-
$r = new ReflectionProperty($events, 'events');
43-
$r->setAccessible(true);
42+
$r = new ReflectionProperty($events, 'events');
4443
$listeners = $r->getValue($events);
4544
return array_keys($listeners);
4645
}
@@ -64,8 +63,7 @@ private function getEventsFromEventManager(EventManager $events)
6463
*/
6564
private function getListenersForEvent($event, EventManager $events, $withPriority = false)
6665
{
67-
$r = new ReflectionProperty($events, 'events');
68-
$r->setAccessible(true);
66+
$r = new ReflectionProperty($events, 'events');
6967
$internal = $r->getValue($events);
7068

7169
$listeners = [];

test/DeprecatedAssertions.php

-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ private static function getPropertyValue(object $instance, string $property)
112112
do {
113113
if ($r->hasProperty($property)) {
114114
$propertyReflection = $r->getProperty($property);
115-
$propertyReflection->setAccessible(true);
116115
return $propertyReflection->getValue($instance);
117116
}
118117
} while ($r = $r->getParentClass());

test/EventManagerTest.php

+2-4
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ protected function setUp(): void
5151
*/
5252
private function getEventListFromManager(EventManager $manager): array
5353
{
54-
$r = new ReflectionProperty($manager, 'events');
55-
$r->setAccessible(true);
54+
$r = new ReflectionProperty($manager, 'events');
5655
$value = $r->getValue($manager);
5756
self::assertIsArray($value);
5857
$keys = array_keys($value);
@@ -69,8 +68,7 @@ private function getEventListFromManager(EventManager $manager): array
6968
*/
7069
private function getListenersForEvent(string $event, EventManager $manager): array
7170
{
72-
$r = new ReflectionProperty($manager, 'events');
73-
$r->setAccessible(true);
71+
$r = new ReflectionProperty($manager, 'events');
7472
$events = $r->getValue($manager);
7573
self::assertIsArray($events);
7674

0 commit comments

Comments
 (0)