Skip to content

Wrong keys for validator messages in multiple languages #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weierophinney opened this issue Dec 31, 2019 · 2 comments
Open

Wrong keys for validator messages in multiple languages #4

weierophinney opened this issue Dec 31, 2019 · 2 comments
Labels
Bug Something isn't working Help Wanted

Comments

@weierophinney
Copy link
Member

Some files in resources still has value variable in keys and values. But there's no value variable in validator. I just updated for Turkish but AR, FI, HR, NO, PL, SE, SR. ZH, ZH_TW affacted. I could updated them too but there's still %value% variable in values.

keys in Zend_Validate file are;

File '%value%' has a false mimetype of '%type%'
The mimetype of file '%value%' could not be detected
File '%value%' is not readable or does not exist

MimeType validator's keys are;

File has an incorrect mimetype of '%type%'
The mimetype could not be detected from the file
File is not readable or does not exist


Originally posted by @Zebercet at zendframework/zend-i18n-resources#36

@froschdesign
Copy link
Member

We must check the message identifiers for conflicts / BC breaks with older versions of laminas-validator.

@CreativeNative
Copy link

Here is also a mistake in the german version.

// Laminas\Validator\EmailAddress
German
"'%hostname%' does not appear to have a valid MX record for the email address '%value%'" => "'%hostname%' scheint keinen gültigen MX Eintrag für die E-Mail-Adresse '%value%' zu haben",

English
"'%hostname%' does not appear to have any valid MX or A records for the email address" => "'%hostname%' does not appear to have any valid MX or A records for the email address",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Help Wanted
Projects
None yet
Development

No branches or pull requests

3 participants