fix: Publish java-specific platform gem #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
force-pushed
the
mk/sdk-1066/publish-java-gems
branch
9 times, most recently
from
68debed to
2ab2187
Compare
When we originally introduced the zlib dependency, we attempted to exclude that dependency in jRuby. However, that exclusion is a build-time check, not run-time as previously though. To support this, we now publish 2 gems -- the standard gem and the *-java specific version. The latter of which is now shipped without the zlib gem requirement.
keelerm84
force-pushed
the
mk/sdk-1066/publish-java-gems
branch
from
2ab2187 to
802472f
Compare
tanderson-ld
approved these changes
Feb 19, 2025
keelerm84
pushed a commit
that referenced
this pull request
Feb 24, 2025
🤖 I have created a release *beep* *boop* --- ## [8.8.3](8.8.2...8.8.3) (2025-02-24) ### Bug Fixes * Publish java-specific platform gem ([#309](#309)) ([b5809f8](b5809f8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we originally introduced the zlib dependency, we attempted to
exclude that dependency in jRuby. However, that exclusion is a
build-time check, not run-time as previously though.
To support this, we now publish 2 gems -- the standard gem and the
*-java specific version. The latter of which is now shipped without the
zlib gem requirement.