Chore: Upgrade node-canvas to v3.1.0

[personalizedrefrigerator]

Summary

This pull request upgrades canvas from v2.11.2 to v3.1.0.

According to the v3.1.0 release, the only breaking change is

Dropped support for Node.js 16.x and below.

canvas also switched from node-pre-gyp to prebuild-install.

Note

pdfjs-dist depends on canvas@npm:^2.11.2. This is overridden in this pull request, using yarn set resolution.

[personalizedrefrigerator]

Closing for now — canvas v3 is causing build issues on Windows.

Error message:

  ➤ YN0000: │ canvas@npm:3.1.0 STDOUT D:\a\joplin\joplin\packages\app-desktop\node_modules\canvas\src\backend\Backend.h(3,10): error C1083: Cannot open include file: 'cairo.h': No such file or directory [D:\a\joplin\joplin\packages\app-desktop\node_modules\canvas\build\canvas.vcxproj]

[laurent22]

For macOS we have this: brew install pango. Maybe we need the equivalent for Windows?

But even better is if we could get rid of canvas as it's causing a lot of problems on all platforms.

[personalizedrefrigerator]

But even better is if we could get rid of canvas as it's causing a lot of problems on all platforms.

Is canvas used in app-cli for OCR? If not, we could try converting the OCR tests to Playwright end-to-end tests.

Edit: OCR seems to be desktop-only — the OCR service is currently only created in app-desktop/app.ts and in tests. pdfToImages (where node-canvas is used) is currently only used in the plugin API and in OCR service.

Edit 2: If converting the OCR tests to Playwright tests isn't feasible, skia-canvas is another NodeJS canvas library we could try.

[laurent22]

As far as I remember, I only added it for the test on CLI. On desktop, we can use the built-in Electron canvas