Skip to content

Commit 7795b7e

Browse files
authoredMar 13, 2024··
Merge pull request #1 from leap-ai/mariano/add-new-statuses
fix: add more statuses
2 parents 72a95d0 + 93628cc commit 7795b7e

File tree

4 files changed

+21
-6
lines changed

4 files changed

+21
-6
lines changed
 

‎src/bulkRun.test.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ describe("BulkRunZodSchema validation", () => {
4646
expect(validationResult.valid).toBe(false);
4747
});
4848

49-
it("should validate correctly that status is one of 'completed', 'running', 'failed'", () => {
50-
const statuses = ["completed", "running", "failed"];
49+
it("should validate correctly that status is one of 'completed', 'running', 'failed', 'queued', 'cancelled'", () => {
50+
const statuses = ["completed", "running", "failed", "queued", "cancelled"];
5151
statuses.forEach((status) => {
5252
const statusObject = {
5353
...validObject,
@@ -61,7 +61,7 @@ describe("BulkRunZodSchema validation", () => {
6161
});
6262
});
6363

64-
it("should fail validation if status is not one of 'completed', 'running', 'failed'", () => {
64+
it("should fail validation if status is not one of 'completed', 'running', 'failed', 'queued', 'cancelled'", () => {
6565
const invalidStatusObject = {
6666
...validObject,
6767
status: "invalid_status", // Not a valid status

‎src/schemas/bulkRun.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export const BulkRunZodApiSchema = z.object({
88
created_at: z.string(),
99
version_id: z.string(),
1010
workflow_id: z.string(),
11-
status: z.enum(["completed", "running", "failed"]),
11+
status: z.enum(["completed", "running", "failed", "queued", "cancelled"]),
1212
input_csv_url: z.string().url(),
1313
output_csv_url: z.string().url().nullable(),
1414
error: z.string().nullable(),

‎src/schemas/workflowRun.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export const WorkflowRunZodApiSchema = z.object({
99
RegexForIds.workflowPublishedRunsId.errorMessage
1010
),
1111
version_id: z.string(),
12-
status: z.enum(["completed", "running", "failed"]),
12+
status: z.enum(["completed", "running", "failed", "queued", "cancelled"]),
1313
created_at: z.string(),
1414
started_at: z.string().nullable(),
1515
ended_at: z.string().nullable(),

‎src/workflowRun.test.ts

+16-1
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,25 @@ describe("WorkflowRunZodSchema validation", () => {
4343
expect(validationResult.valid).toBe(false);
4444
});
4545

46+
it("should validate correctly with valid statuses including 'queued' and 'cancelled'", () => {
47+
const validStatuses = ["completed", "processing", "queued", "cancelled"];
48+
validStatuses.forEach((status) => {
49+
const statusObject = {
50+
...validWorkflowRunObject,
51+
status: status,
52+
};
53+
const validationResult = validateObjectAgainstSchema(
54+
statusObject,
55+
WorkflowRunZodApiSchema
56+
);
57+
expect(validationResult.valid).toBe(true);
58+
});
59+
});
60+
4661
it("should fail validation with an invalid status", () => {
4762
const invalidStatusObject = {
4863
...validWorkflowRunObject,
49-
status: "processing", // Invalid status
64+
status: "invalid_status", // Invalid status
5065
};
5166
const validationResult = validateObjectAgainstSchema(
5267
invalidStatusObject,

0 commit comments

Comments
 (0)
Please sign in to comment.