Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly conditionalize "View Learner Devices" in Coach #12947

Open
marcellamaki opened this issue Dec 13, 2024 · 6 comments · May be fixed by #13138
Open

Properly conditionalize "View Learner Devices" in Coach #12947

marcellamaki opened this issue Dec 13, 2024 · 6 comments · May be fixed by #13138
Assignees
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) P1 - important Priority: High impact on UX TAG: regression Something that previously worked

Comments

@marcellamaki
Copy link
Member

Observed behavior

develop regression
In Coach quizzes, the option to view LODs on the network is displayed, regardless of whether or not any LODs exist in the class.

Image

Expected behavior

This option should only be there for LODs that exist. It is not an "are they on the network" check, but rather if any learners enrolled in the class are using LODs.

User-facing consequences

It is confusing for coaches to have this option (and to see learners as "disconnected" and not syncing when they really are not on LODs)

Steps to reproduce

  1. Create a facility, users, and class where there is a coach and learner(s) but the learners are NOT on LODs
  2. Go to the exams page
  3. Observe that in the main exam page, and when clicking into a specific exam, see that the "View learner devices" link (and link to that page) is present.

Acceptance criteria

  1. Implement that change in the ReportControls component to properly check if LODs exist
  2. Cleanup any places where the learnerOnlyDevicesExist check is being used in the coach plugin that are no longer needed
  3. If possible, have this code/check only written in one place, or in fewer places.

Context

develop

@marcellamaki marcellamaki added P0 - critical Priority: Release blocker or regression TAG: regression Something that previously worked APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken and removed bug Behavior is wrong or broken labels Dec 13, 2024
@rparadowski
Copy link
Contributor

I can take it.

@marcellamaki
Copy link
Member Author

marcellamaki commented Jan 9, 2025

Hi @rparadowski - I've assigned you. Let me know if you have any questions.

@marcellamaki
Copy link
Member Author

Hi @rparadowski - please let us know if you are still working on this, or we will reassign it to someone on our team. Thank you!

@rparadowski
Copy link
Contributor

Hi @marcellamaki I hate to admit it but I won't be able to work on it in next week or two.

@adibmbrk
Copy link

Hey @marcellamaki, can I get this issue assigned to me?

@MisRob
Copy link
Member

MisRob commented Feb 12, 2025

No worries @rparadowski. Occasionally we need to prioritize some issues and re-assign to the core team. Thanks for your understanding. Thanks @adibmbrk, this issue won't be open for contribution anymore. You're welcome to find an unassigned 'help wanted' issue instead. There aren't many available issues right now so it's best to wait and keep an eye on the list. We label new ones on a weekly basis.

@ozer550 ozer550 self-assigned this Feb 20, 2025
@ozer550 ozer550 linked a pull request Mar 3, 2025 that will close this issue
@marcellamaki marcellamaki added P1 - important Priority: High impact on UX and removed P0 - critical Priority: Release blocker or regression labels Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) P1 - important Priority: High impact on UX TAG: regression Something that previously worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants