- fix: replacing useProvider with useStream, avoiding exception "Bad state: Stream has already been listened to." on console.dart

- fix: crash on search bar when there aren't results
- cleaned code on version_install_button.dart and app_bottom_bar.dart

Author: federicoviceconti

lib/src/components/atoms/console.dart

@@ -2,7 +2,6 @@ import 'package:flutter/cupertino.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_hooks/flutter_hooks.dart';
 import 'package:flutter_spinkit/flutter_spinkit.dart';
-import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:material_design_icons_flutter/material_design_icons_flutter.dart';
 
 import '../../modules/fvm/fvm.provider.dart';
@@ -21,11 +20,11 @@ class Console extends HookWidget {
 
   @override
   Widget build(BuildContext context) {
-    final output = useProvider(fvmStdoutProvider);
+    final output = useStream(fvmStdoutProvider);
     final lines = useState<List<String>>(['']);
 
     useValueChanged(output, (_, __) {
-      lines.value.insert(0, output.data.value);
+      lines.value.insert(0, output.data);
       if (lines.value.length > 100) {
         lines.value.removeAt(lines.value.length - 1);
       }
@@ -65,7 +64,10 @@ class Console extends HookWidget {
                     mainAxisAlignment: MainAxisAlignment.start,
                     crossAxisAlignment: CrossAxisAlignment.center,
                     children: [
-                      ConsoleText(lines.value.first),
+                      Container(
+                          width: MediaQuery.of(context).size.width - 100,
+                          child: ConsoleText(lines.value.first)
+                      ),
                     ],
                   ),
                 ),

lib/src/components/atoms/sliver_header_delegate.dart

@@ -41,7 +41,7 @@ class SliverHeaderDelegate extends SliverPersistentHeaderDelegate {
         ),
         trailing: Text(
           I18Next.of(context).t('components:atoms.countFound', variables: {
-            'count': count.toString(),
+            'count': count,
           }),
         ),
         onTap: onPress,

lib/src/components/molecules/version_install_button.dart

@@ -89,7 +89,7 @@ class VersionInstallButton extends HookWidget {
       child: Opacity(
         opacity: (version?.isCached ?? false) ? 0.3 : 1,
         child: IconButton(
-          onPressed: (version?.isCached ?? false) ? onInstall : onInstall,
+          onPressed: onInstall,
           splashRadius: 20,
           icon: Tooltip(
               message:

lib/src/components/organisms/app_bottom_bar.dart

@@ -17,7 +17,7 @@ class AppBottomBar extends HookWidget {
       expand.value = !expand.value;
     }
 
-    if (processing == false) {
+    if (!processing) {
       return Container(height: 0);
     }
 

lib/src/modules/fvm/fvm.provider.dart

@@ -119,14 +119,11 @@ class FvmCacheProvider extends StateNotifier<List<CacheVersion>> {
   }
 }
 
-final fvmStdoutProvider = StreamProvider.autoDispose((ref) {
-  return StreamGroup.merge([
-    FVMClient.console.stdout.stream,
-    FVMClient.console.stderr.stream,
-    FVMClient.console.warning.stream,
-    FVMClient.console.info.stream,
-    FVMClient.console.fine.stream,
-    FVMClient.console.error.stream,
-  ]).transform(utf8.decoder);
-  // .transform(const LineSplitter())
-});
+final fvmStdoutProvider = StreamGroup.mergeBroadcast([
+  FVMClient.console.stdout.stream,
+  FVMClient.console.stderr.stream,
+  FVMClient.console.warning.stream,
+  FVMClient.console.info.stream,
+  FVMClient.console.fine.stream,
+  FVMClient.console.error.stream,
+]).transform(utf8.decoder);

macos/Podfile.lock

@@ -43,4 +43,4 @@ SPEC CHECKSUMS:
 
 PODFILE CHECKSUM: 6eac6b3292e5142cfc23bdeb71848a40ec51c14c
 
-COCOAPODS: 1.10.1
+COCOAPODS: 1.11.0

pubspec.lock

@@ -42,7 +42,7 @@ packages:
       name: async
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.8.1"
+    version: "2.8.2"
   boolean_selector:
     dependency: transitive
     description:
@@ -119,7 +119,7 @@ packages:
       name: characters
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.1.0"
+    version: "1.2.0"
   charcode:
     dependency: transitive
     description:
@@ -491,7 +491,7 @@ packages:
       name: matcher
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.12.10"
+    version: "0.12.11"
   material_design_icons_flutter:
     dependency: "direct main"
     description:
@@ -825,7 +825,7 @@ packages:
       name: test_api
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.4.2"
+    version: "0.4.3"
   timing:
     dependency: transitive
     description:
@@ -902,7 +902,7 @@ packages:
       name: vector_math
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "2.1.0"
+    version: "2.1.1"
   watcher:
     dependency: "direct main"
     description: