Skip to content

Commit 9cf5294

Browse files
wodkawodka
authored and
wodka
committed
* implement interlace filter
* add functional and unit test * move functional tests (DataManager and FilterManager) to subfolders
1 parent f45d5cc commit 9cf5294

File tree

5 files changed

+48
-4
lines changed

5 files changed

+48
-4
lines changed

Imagine/Filter/Loader/InterlaceFilterLoader.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ class InterlaceFilterLoader implements LoaderInterface
1212
public function load(ImageInterface $image, array $options = array())
1313
{
1414
$mode = ImageInterface::INTERLACE_LINE;
15-
if (empty($options['mode']) {
15+
if (!empty($options['mode'])) {
1616
$mode = $options['mode'];
1717
}
1818

19-
$image->interlace(ImageInterface::INTERLACE_LINE);
19+
$image->interlace($mode);
2020

2121
return $image;
2222
}

Tests/Functional/Imagine/DataManagerTest.php Tests/Functional/Imagine/Data/DataManagerTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?php
2-
namespace Liip\ImagineBundle\Tests\Functional\Imagine;
2+
namespace Liip\ImagineBundle\Tests\Functional\Imagine\Data;
33

44
use Liip\ImagineBundle\Tests\Functional\WebTestCase;
55

Tests/Functional/Imagine/FilterManagerTest.php Tests/Functional/Imagine/Filter/FilterManagerTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?php
2-
namespace Liip\ImagineBundle\Tests\Functional\Imagine;
2+
namespace Liip\ImagineBundle\Tests\Functional\Imagine\Filter;
33

44
use Liip\ImagineBundle\Tests\Functional\WebTestCase;
55

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?php
2+
namespace Liip\ImagineBundle\Tests\Functional\Imagine\Filter\Loader;
3+
4+
use Liip\ImagineBundle\Tests\Functional\WebTestCase;
5+
6+
class InterlaceFilterLoaderTest extends WebTestCase
7+
{
8+
public function testCouldBeGetFromContainerAsService()
9+
{
10+
$this->createClient();
11+
$service = self::$kernel->getContainer()->get('liip_imagine.filter.loader.interlace');
12+
13+
$this->assertInstanceOf('Liip\ImagineBundle\Imagine\Filter\Loader\InterlaceFilterLoader', $service);
14+
}
15+
}
16+
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
<?php
2+
3+
namespace Liip\ImagineBundle\Tests\Filter;
4+
5+
use Liip\ImagineBundle\Imagine\Filter\Loader\InterlaceFilterLoader;
6+
use Liip\ImagineBundle\Tests\AbstractTest;
7+
8+
/**
9+
* @covers Liip\ImagineBundle\Imagine\Filter\Loader\InterlaceFilterLoader
10+
*/
11+
class InterlaceFilterLoaderTest extends AbstractTest
12+
{
13+
public function testLoad()
14+
{
15+
$loader = new InterlaceFilterLoader();
16+
17+
$image = $this->getMockImage();
18+
$image
19+
->expects($this->once())
20+
->method('interlace')
21+
->with('TEST')
22+
;
23+
24+
$result = $loader->load($image, array('mode' => 'TEST'));
25+
26+
$this->assertInstanceOf('Imagine\Image\ImageInterface', $result);
27+
}
28+
}

0 commit comments

Comments
 (0)