Skip to content

Commit e6cc0fa

Browse files
committed
[runtimes] Don't use -Wall on clang-cl builds
`-Wall` on clang-cl is equivalent to `-Weverything` on clang. We already add the correct warning flag depending whether we are in an MSVC-like environment, so just remove it from the list of flags that get passed unconditionally. Spies: libcxx-commits Differential Revision: https://reviews.llvm.org/D146378
1 parent 4601bcd commit e6cc0fa

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

runtimes/cmake/Modules/WarningFlags.cmake

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ function(cxx_add_warning_flags target enable_werror enable_pedantic)
1212
endif()
1313
# TODO: Should -Wconversion be enabled?
1414
target_add_compile_flags_if_supported(${target} PRIVATE
15-
-Wall
1615
-Wextra
1716
-Wnewline-eof
1817
-Wshadow

0 commit comments

Comments
 (0)