Skip to content

Commit 13f209c

Browse files
authored
chore: source code formatting uses semicolons for all TS/JS now (#1418)
Lots of linting config updates as part of the update of prettier and some other dependencies
1 parent d72540a commit 13f209c

File tree

878 files changed

+41262
-41494
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

878 files changed

+41262
-41494
lines changed

.github/pull_request_template.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
## Developer Checklist [ℹ️](https://github.com/looker-open-source/sdk-codegen/blob/main/CONTRIBUTING.md#developer-checklist)
88

99
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
10-
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/looker-open-source/sdk-codegen/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
10+
11+
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/looker-open-source/sdk-codegen/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
1112
- [ ] Ensure the tests and linter pass
1213
- [ ] Appropriate docs were updated (if necessary)
1314

.github/workflows/go-ci.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ jobs:
7070
uses: looker-open-source/reusable-actions/.github/workflows/supported-versions.yml@main
7171

7272
integration:
73-
needs: [setup,unit]
73+
needs: [setup, unit]
7474
name: Integration - ${{ matrix.os }} / Looker.${{ matrix.looker }}
7575
env:
7676
LOOKERSDK_CLIENT_ID: ${{ secrets.LOOKERSDK_CLIENT_ID }}
@@ -85,7 +85,8 @@ jobs:
8585
matrix:
8686
os:
8787
- ubuntu
88-
looker: ${{ fromJson(needs.setup.outputs.matrix_json) }}
88+
looker:
89+
${{ fromJson(needs.setup.outputs.matrix_json) }}
8990

9091
# TODO uncomment `include:` when either macos or windows works to satisfaction.
9192
#include:

.github/workflows/p3-issue-label.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ jobs:
1818
owner: context.repo.owner,
1919
repo: context.repo.repo,
2020
labels: ["p3"]
21-
})
21+
})

.github/workflows/python-ci.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
path: python/results/
9999

100100
integration:
101-
needs: [unit,setup]
101+
needs: [unit, setup]
102102
name: Integration - ${{ matrix.os }} / Looker.${{ matrix.looker }}
103103
env:
104104
TOX_JUNIT_OUTPUT_NAME: ${{ matrix.os }}.Looker-${{ matrix.looker }}.py3.x
@@ -117,10 +117,11 @@ jobs:
117117
matrix:
118118
os:
119119
- large-ubuntu
120-
looker: ${{ fromJson(needs.setup.outputs.matrix_json) }}
120+
looker:
121+
${{ fromJson(needs.setup.outputs.matrix_json) }}
121122

122123
# TODO uncomment `include:` when either macos or windows works to satisfaction.
123-
#include:
124+
#include:
124125
# TODO: macos matrix leg is functional but it takes ~20 minutes (compared
125126
# to ~4 minutes for ubuntu) because docker install takes ~5 minutes
126127
# and docker pull takes ~10 minutes. We can probably figure out how to

.github/workflows/release-metrics.yml

+12-12
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,16 @@ jobs:
1818
uses: google-github-actions/[email protected]
1919

2020
- run: 'jq -c ''.release |
21-
{
22-
package_name: .name | split(" ")[0],
23-
name,
24-
tag_name,
25-
version: .tag_name | split("-v")[1],
26-
html_url,
27-
target_commitish,
28-
created_at,
29-
published_at,
30-
draft,
31-
prerelease
32-
}'' $GITHUB_EVENT_PATH > releases.json'
21+
{
22+
package_name: .name | split(" ")[0],
23+
name,
24+
tag_name,
25+
version: .tag_name | split("-v")[1],
26+
html_url,
27+
target_commitish,
28+
created_at,
29+
published_at,
30+
draft,
31+
prerelease
32+
}'' $GITHUB_EVENT_PATH > releases.json'
3333
- run: bq load --source_format=NEWLINE_DELIMITED_JSON metrics.releases releases.json

.github/workflows/triage-issue-label.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ jobs:
1717
owner: context.repo.owner,
1818
repo: context.repo.repo,
1919
labels: ["need triage"]
20-
})
20+
})

.github/workflows/tssdk-ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ jobs:
112112
setup:
113113
uses: looker-open-source/reusable-actions/.github/workflows/supported-versions.yml@main
114114
integration:
115-
needs: [unit,setup]
115+
needs: [unit, setup]
116116
name: Integration - ${{ matrix.os }} / Node.${{ matrix.node-version }} / Looker.${{ matrix.looker }}
117117
env:
118118
JEST_JUNIT_OUTPUT_DIR: results/tssdk

.prettierignore

+9-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1-
**/node_modules/*
2-
packages/**/lib/
3-
1+
*.md
2+
**/*.md
3+
**/*.mdx
4+
**/dist
5+
**/lib
6+
**/storybook-static
7+
**/test/output
8+
**/.eslintrc
9+
*.lock

.prettierrc.js

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
// module.exports = require("@looker/prettier-config");
2+
const config = {
3+
// SSchema: "https://json.schemastore.org/prettierrc",
4+
semi: true,
5+
singleQuote: true,
6+
trailingComma: 'es5',
7+
};
8+
module.exports = config;

.prettierrc.json

-5
This file was deleted.

0 commit comments

Comments
 (0)