Skip to content

Commit c687692

Browse files
authored
chore: Update sdk_gen script to lint and not do smoke tests (#1431)
- Removed smoke tests as our CI already runs them. - Added python and kotlin linting to the script - Added `yarn fix` to the script. For some reason, our pre-commit hook hangs on eslint. So if we first fix the eslint issues with `yarn fix` this lets our pre-commit hook work. Additionally: - Updated our playbook with additional setup steps for linting - Updated our playbook and console output with smoke test debugging steps if CI breaks Confirmed it generates sdk with consistent styling. From last generation: `26 files changed, 519 insertions(+), 188 deletions(-)`
1 parent 8dacdf2 commit c687692

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

bin/sdk_gen

+4-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,9 @@ const regen = async (release) => {
193193
return batch(
194194
[
195195
'yarn gen',
196-
'bin/smoke typescript python kotlin',
196+
'yarn fix', // Lint fix typescript
197+
'pipenv run black python/looker_sdk/sdk/api40/*.py', // Lint fix python
198+
'./kotlin/gradlew -p kotlin spotlessApply', // Lint fix kotlin
197199
'git add -u',
198200
`git commit -m "feat: generate SDKs for Looker ${release}" -m "Release-As: ${release}.0"`,
199201
`git push origin ${branch}`,
@@ -214,6 +216,7 @@ const regen = async (release) => {
214216
const args = process.argv.slice(2);
215217
if (args.length >= 1) {
216218
await regen(args[0]);
219+
console.info('If generated SDKs fail CI, run "bin/smoke [language]" locally to verify and debug')
217220
} else {
218221
console.error('No release version was specified');
219222
}

0 commit comments

Comments
 (0)