-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: error-doc handling in python SDK #1440
Conversation
dfc272e
to
b06350e
Compare
b06350e
to
a80f140
Compare
Sample output after adding some prints to
|
Python Tests 9 files 9 suites 1m 46s ⏱️ Results for commit a80f140. |
Updated the SDKError and ErrorDoc objects with a
|
Python Tests 9 files 9 suites 1m 58s ⏱️ Results for commit e264d2d. |
Python Tests 8 files 8 suites 1m 19s ⏱️ For more details on these errors, see this check. Results for commit e89193c. |
Python Tests 9 files 9 suites 1m 45s ⏱️ Results for commit e89193c. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a slightly different implementation than we have for other SDKs due to needing to keep SDKs like TS as lean as possible, but this feels like it could be a good approach for the Python SDK, and perhaps some of the others. Will consider it for other SDK implementations.
This comment has been minimized.
This comment has been minimized.
🤖 I have created a release *beep* *boop* --- <details><summary>@looker/api-explorer: 0.9.58</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-utils bumped from 0.1.34 to 0.1.35 * @looker/run-it bumped from 0.9.57 to 0.9.58 * @looker/sdk bumped from 24.2.0 to 24.2.1 * devDependencies * @looker/sdk-codegen-scripts bumped from 21.5.14 to 21.5.15 * @looker/sdk-node bumped from 24.2.0 to 24.2.1 </details> <details><summary>@looker/extension-api-explorer: 22.21.15</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/api-explorer bumped from 0.9.57 to 0.9.58 * @looker/extension-sdk bumped from 24.2.0 to 24.2.1 * @looker/extension-sdk-react bumped from 24.2.0 to 24.2.1 * @looker/extension-utils bumped from 0.1.34 to 0.1.35 * @looker/run-it bumped from 0.9.57 to 0.9.58 * @looker/sdk bumped from 24.2.0 to 24.2.1 </details> <details><summary>@looker/extension-playground: 1.0.15</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.2.0 to 24.2.1 * @looker/extension-sdk-react bumped from 24.2.0 to 24.2.1 * @looker/sdk bumped from 24.2.0 to 24.2.1 </details> <details><summary>@looker/extension-tile-playground: 1.1.2</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.2.0 to 24.2.1 * @looker/extension-sdk-react bumped from 24.2.0 to 24.2.1 * @looker/sdk bumped from 24.2.0 to 24.2.1 </details> <details><summary>@looker/extension-utils: 0.1.35</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.2.0 to 24.2.1 * @looker/extension-sdk-react bumped from 24.2.0 to 24.2.1 * @looker/sdk bumped from 24.2.0 to 24.2.1 </details> <details><summary>@looker/hackathon: 22.21.17</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.2.0 to 24.2.1 * @looker/extension-sdk-react bumped from 24.2.0 to 24.2.1 * @looker/extension-utils bumped from 0.1.34 to 0.1.35 * @looker/sdk bumped from 24.2.0 to 24.2.1 * @looker/wholly-artifact bumped from 0.1.15 to 0.1.16 </details> <details><summary>@looker/run-it: 0.9.58</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-utils bumped from 0.1.34 to 0.1.35 * @looker/sdk bumped from 24.2.0 to 24.2.1 </details> <details><summary>@looker/sdk-codegen-scripts: 21.5.15</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.2.0 to 24.2.1 * @looker/sdk-node bumped from 24.2.0 to 24.2.1 </details> <details><summary>@looker/wholly-artifact: 0.1.16</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.2.0 to 24.2.1 * devDependencies * @looker/sdk-node bumped from 24.2.0 to 24.2.1 </details> <details><summary>@looker/wholly-sheet: 0.5.54</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.2.0 to 24.2.1 * devDependencies * @looker/sdk-node bumped from 24.2.0 to 24.2.1 </details> <details><summary>sdk-codegen-all: 24.3.0</summary> ## [24.3.0](sdk-codegen-all-v24.2.0...sdk-codegen-all-v24.3.0) (2024-03-12) ### Features * error-doc handling in python SDK ([#1440](#1440)) ([21daada](21daada)) </details> <details><summary>looker_sdk: 24.2.1</summary> ## [24.2.1](looker_sdk-v24.2.0...looker_sdk-v24.2.1) (2024-03-12) ### Features * error-doc handling in python SDK ([#1440](#1440)) ([21daada](21daada)) </details> <details><summary>embed-components: 24.2.1</summary> ## [24.2.1](embed-components-v24.2.0...embed-components-v24.2.1) (2024-03-12) ### Miscellaneous Chores * **embed-components:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/embed-services bumped from 24.2.0 to 24.2.1 * @looker/sdk bumped from 24.2.0 to 24.2.1 * devDependencies * @looker/sdk-node bumped from 24.2.0 to 24.2.1 </details> <details><summary>embed-services: 24.2.1</summary> ## [24.2.1](embed-services-v24.2.0...embed-services-v24.2.1) (2024-03-12) ### Miscellaneous Chores * **embed-services:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.2.0 to 24.2.1 * devDependencies * @looker/sdk-node bumped from 24.2.0 to 24.2.1 </details> <details><summary>extension-sdk: 24.2.1</summary> ## [24.2.1](extension-sdk-v24.2.0...extension-sdk-v24.2.1) (2024-03-12) ### Miscellaneous Chores * **extension-sdk:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.2.0 to 24.2.1 </details> <details><summary>extension-sdk-react: 24.2.1</summary> ## [24.2.1](extension-sdk-react-v24.2.0...extension-sdk-react-v24.2.1) (2024-03-12) ### Miscellaneous Chores * **extension-sdk-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.2.0 to 24.2.1 * @looker/sdk bumped from 24.2.0 to 24.2.1 </details> <details><summary>sdk: 24.2.1</summary> ## [24.2.1](sdk-v24.2.0...sdk-v24.2.1) (2024-03-12) ### Miscellaneous Chores * **sdk:** Synchronize undefined versions </details> <details><summary>sdk-node: 24.2.1</summary> ## [24.2.1](sdk-node-v24.2.0...sdk-node-v24.2.1) (2024-03-12) ### Miscellaneous Chores * **sdk-node:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.2.0 to 24.2.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Lookups now take place against the CDN to find a more detailed error guide. The url to that error guide, and the error guide itself - a markdown document - are included in the SDKError class and the ErrorDetail class.