Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python SDKError): Fixed SDKError __str__ #1480

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix(python SDKError): Fixed SDKError __str__ #1480

merged 2 commits into from
Jul 29, 2024

Conversation

syvokobylka
Copy link
Contributor

@syvokobylka syvokobylka commented Jul 4, 2024 •
edited
Loading

Fix for the issue: attempt to represent python SDKError object as a string leads to TypeError exception ahppening, since python join() doesn't convert ErrorDetail object to string automatically.

Developer Checklist ℹ️

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #1479 🦕

@syvokobylka syvokobylka requested a review from a team as a code owner July 4, 2024 09:09
@google-cla Google CLA
Copy link

google-cla bot commented Jul 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@drstrangelooker drstrangelooker changed the base branch from main to python_SDKError_str_fix-internal July 29, 2024 20:42
drstrangelooker
drstrangelooker approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@drstrangelooker drstrangelooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drstrangelooker drstrangelooker merged commit dbb2572 into looker-open-source:python_SDKError_str_fix-internal Jul 29, 2024
10 of 15 checks passed
@drstrangelooker
Copy link
Collaborator

We can only test code in local branches, so pulled it into a local branch and created a new PR1486

drstrangelooker added a commit that referenced this pull request Jul 29, 2024
@drstrangelooker @syvokobylka
fix(python SDKError): Fixed SDKError __str__ (#1480) (#1486)
d8907fe 
Co-authored-by: syvokobylka <[email protected]>
Merged
drstrangelooker pushed a commit that referenced this pull request Jul 29, 2024
@looker-open-source-automation-bot
chore: release main (#1487)
e593102 
🤖 I have created a release *beep* *boop*
---


<details><summary>@looker/api-explorer: 0.9.63</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-utils bumped from 0.1.39 to 0.1.40
    * @looker/run-it bumped from 0.9.62 to 0.9.63
    * @looker/sdk bumped from 24.12.0 to 24.12.1
  * devDependencies
    * @looker/sdk-codegen-scripts bumped from 21.5.19 to 21.5.20
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/extension-api-explorer: 22.21.20</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/api-explorer bumped from 0.9.62 to 0.9.63
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1
    * @looker/extension-utils bumped from 0.1.39 to 0.1.40
    * @looker/run-it bumped from 0.9.62 to 0.9.63
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/extension-playground: 1.0.20</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/extension-tile-playground: 1.1.7</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/extension-utils: 0.1.40</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/hackathon: 22.21.22</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1
    * @looker/extension-utils bumped from 0.1.39 to 0.1.40
    * @looker/sdk bumped from 24.12.0 to 24.12.1
    * @looker/wholly-artifact bumped from 0.1.20 to 0.1.21
</details>

<details><summary>@looker/run-it: 0.9.63</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-utils bumped from 0.1.39 to 0.1.40
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/sdk-codegen-scripts: 21.5.20</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/wholly-artifact: 0.1.21</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
  * devDependencies
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/wholly-sheet: 0.5.59</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
  * devDependencies
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>sdk-codegen-all: 24.12.1</summary>

##
[24.12.1](sdk-codegen-all-v24.12.0...sdk-codegen-all-v24.12.1)
(2024-07-29)


### Bug Fixes

* **python SDKError:** Fixed SDKError __str__
([#1480](#1480))
([#1486](#1486))
([d8907fe](d8907fe))
</details>

<details><summary>looker_sdk: 24.12.1</summary>

##
[24.12.1](looker_sdk-v24.12.0...looker_sdk-v24.12.1)
(2024-07-29)


### Bug Fixes

* **python SDKError:** Fixed SDKError __str__
([#1480](#1480))
([#1486](#1486))
([d8907fe](d8907fe))
</details>

<details><summary>embed-components: 24.12.1</summary>

##
[24.12.1](embed-components-v24.12.0...embed-components-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **embed-components:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/embed-services bumped from 24.12.0 to 24.12.1
    * @looker/sdk bumped from 24.12.0 to 24.12.1
  * devDependencies
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>embed-services: 24.12.1</summary>

##
[24.12.1](embed-services-v24.12.0...embed-services-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **embed-services:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
  * devDependencies
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>extension-sdk: 24.12.1</summary>

##
[24.12.1](extension-sdk-v24.12.0...extension-sdk-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **extension-sdk:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>extension-sdk-react: 24.12.1</summary>

##
[24.12.1](extension-sdk-react-v24.12.0...extension-sdk-react-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **extension-sdk-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>sdk: 24.12.1</summary>

##
[24.12.1](sdk-v24.12.0...sdk-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **sdk:** Synchronize undefined versions
</details>

<details><summary>sdk-node: 24.12.1</summary>

##
[24.12.1](sdk-node-v24.12.0...sdk-node-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **sdk-node:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
JCPistell pushed a commit that referenced this pull request Aug 29, 2024
@drstrangelooker @syvokobylka @JCPistell
fix(python SDKError): Fixed SDKError __str__ (#1480) (#1486)
33fa834 
Co-authored-by: syvokobylka <[email protected]>
JCPistell pushed a commit that referenced this pull request Aug 29, 2024
@looker-open-source-automation-bot @JCPistell
chore: release main (#1487)
8b81e88 
🤖 I have created a release *beep* *boop*
---


<details><summary>@looker/api-explorer: 0.9.63</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-utils bumped from 0.1.39 to 0.1.40
    * @looker/run-it bumped from 0.9.62 to 0.9.63
    * @looker/sdk bumped from 24.12.0 to 24.12.1
  * devDependencies
    * @looker/sdk-codegen-scripts bumped from 21.5.19 to 21.5.20
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/extension-api-explorer: 22.21.20</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/api-explorer bumped from 0.9.62 to 0.9.63
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1
    * @looker/extension-utils bumped from 0.1.39 to 0.1.40
    * @looker/run-it bumped from 0.9.62 to 0.9.63
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/extension-playground: 1.0.20</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/extension-tile-playground: 1.1.7</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/extension-utils: 0.1.40</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/hackathon: 22.21.22</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1
    * @looker/extension-utils bumped from 0.1.39 to 0.1.40
    * @looker/sdk bumped from 24.12.0 to 24.12.1
    * @looker/wholly-artifact bumped from 0.1.20 to 0.1.21
</details>

<details><summary>@looker/run-it: 0.9.63</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-utils bumped from 0.1.39 to 0.1.40
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/sdk-codegen-scripts: 21.5.20</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/wholly-artifact: 0.1.21</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
  * devDependencies
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>@looker/wholly-sheet: 0.5.59</summary>

### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
  * devDependencies
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>sdk-codegen-all: 24.12.1</summary>

##
[24.12.1](sdk-codegen-all-v24.12.0...sdk-codegen-all-v24.12.1)
(2024-07-29)


### Bug Fixes

* **python SDKError:** Fixed SDKError __str__
([#1480](#1480))
([#1486](#1486))
([d8907fe](d8907fe))
</details>

<details><summary>looker_sdk: 24.12.1</summary>

##
[24.12.1](looker_sdk-v24.12.0...looker_sdk-v24.12.1)
(2024-07-29)


### Bug Fixes

* **python SDKError:** Fixed SDKError __str__
([#1480](#1480))
([#1486](#1486))
([d8907fe](d8907fe))
</details>

<details><summary>embed-components: 24.12.1</summary>

##
[24.12.1](embed-components-v24.12.0...embed-components-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **embed-components:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/embed-services bumped from 24.12.0 to 24.12.1
    * @looker/sdk bumped from 24.12.0 to 24.12.1
  * devDependencies
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>embed-services: 24.12.1</summary>

##
[24.12.1](embed-services-v24.12.0...embed-services-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **embed-services:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
  * devDependencies
    * @looker/sdk-node bumped from 24.12.0 to 24.12.1
</details>

<details><summary>extension-sdk: 24.12.1</summary>

##
[24.12.1](extension-sdk-v24.12.0...extension-sdk-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **extension-sdk:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>extension-sdk-react: 24.12.1</summary>

##
[24.12.1](extension-sdk-react-v24.12.0...extension-sdk-react-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **extension-sdk-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/extension-sdk bumped from 24.12.0 to 24.12.1
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

<details><summary>sdk: 24.12.1</summary>

##
[24.12.1](sdk-v24.12.0...sdk-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **sdk:** Synchronize undefined versions
</details>

<details><summary>sdk-node: 24.12.1</summary>

##
[24.12.1](sdk-node-v24.12.0...sdk-node-v24.12.1)
(2024-07-29)


### Miscellaneous Chores

* **sdk-node:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @looker/sdk bumped from 24.12.0 to 24.12.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drstrangelooker drstrangelooker drstrangelooker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python SDKError __str__ bug
2 participants
@syvokobylka @drstrangelooker