fix(python SDKError): Fixed SDKError str (#1480) #1486

drstrangelooker · 2024-07-29T20:44:13Z

No description provided.

Fix for the issue: attempt to represent python SDKError object as a string leads to TypeError exception ahppening, since python join() doesn't convert ErrorDetail object to string automatically. ## Developer Checklist [ℹ️](https://github.com/looker-open-source/sdk-codegen/blob/main/CONTRIBUTING.md#developer-checklist) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/looker-open-source/sdk-codegen/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Appropriate docs were updated (if necessary) Fixes #1479 🦕

drstrangelooker · 2024-07-29T20:46:40Z

@syvokobylka

github-actions · 2024-07-29T20:53:51Z

Python Tests

9 files ±0 9 suites ±0 1m 18s ⏱️ -1s
144 tests ±0 139 ✅ ±0 5 💤 ±0 0 ❌ ±0
676 runs ±0 657 ✅ ±0 19 💤 ±0 0 ❌ ±0

Results for commit dbb2572. ± Comparison against base commit 060b701.

🤖 I have created a release *beep* *boop* --- <details><summary>@looker/api-explorer: 0.9.63</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-utils bumped from 0.1.39 to 0.1.40 * @looker/run-it bumped from 0.9.62 to 0.9.63 * @looker/sdk bumped from 24.12.0 to 24.12.1 * devDependencies * @looker/sdk-codegen-scripts bumped from 21.5.19 to 21.5.20 * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/extension-api-explorer: 22.21.20</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/api-explorer bumped from 0.9.62 to 0.9.63 * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1 * @looker/extension-utils bumped from 0.1.39 to 0.1.40 * @looker/run-it bumped from 0.9.62 to 0.9.63 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/extension-playground: 1.0.20</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/extension-tile-playground: 1.1.7</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/extension-utils: 0.1.40</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/hackathon: 22.21.22</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1 * @looker/extension-utils bumped from 0.1.39 to 0.1.40 * @looker/sdk bumped from 24.12.0 to 24.12.1 * @looker/wholly-artifact bumped from 0.1.20 to 0.1.21 </details> <details><summary>@looker/run-it: 0.9.63</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-utils bumped from 0.1.39 to 0.1.40 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/sdk-codegen-scripts: 21.5.20</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/wholly-artifact: 0.1.21</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 * devDependencies * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/wholly-sheet: 0.5.59</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 * devDependencies * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>sdk-codegen-all: 24.12.1</summary> ## [24.12.1](sdk-codegen-all-v24.12.0...sdk-codegen-all-v24.12.1) (2024-07-29) ### Bug Fixes * **python SDKError:** Fixed SDKError __str__ ([#1480](#1480)) ([#1486](#1486)) ([d8907fe](d8907fe)) </details> <details><summary>looker_sdk: 24.12.1</summary> ## [24.12.1](looker_sdk-v24.12.0...looker_sdk-v24.12.1) (2024-07-29) ### Bug Fixes * **python SDKError:** Fixed SDKError __str__ ([#1480](#1480)) ([#1486](#1486)) ([d8907fe](d8907fe)) </details> <details><summary>embed-components: 24.12.1</summary> ## [24.12.1](embed-components-v24.12.0...embed-components-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **embed-components:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/embed-services bumped from 24.12.0 to 24.12.1 * @looker/sdk bumped from 24.12.0 to 24.12.1 * devDependencies * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>embed-services: 24.12.1</summary> ## [24.12.1](embed-services-v24.12.0...embed-services-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **embed-services:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 * devDependencies * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>extension-sdk: 24.12.1</summary> ## [24.12.1](extension-sdk-v24.12.0...extension-sdk-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **extension-sdk:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>extension-sdk-react: 24.12.1</summary> ## [24.12.1](extension-sdk-react-v24.12.0...extension-sdk-react-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **extension-sdk-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>sdk: 24.12.1</summary> ## [24.12.1](sdk-v24.12.0...sdk-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **sdk:** Synchronize undefined versions </details> <details><summary>sdk-node: 24.12.1</summary> ## [24.12.1](sdk-node-v24.12.0...sdk-node-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **sdk-node:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: syvokobylka <[email protected]>

🤖 I have created a release *beep* *boop* --- <details><summary>@looker/api-explorer: 0.9.63</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-utils bumped from 0.1.39 to 0.1.40 * @looker/run-it bumped from 0.9.62 to 0.9.63 * @looker/sdk bumped from 24.12.0 to 24.12.1 * devDependencies * @looker/sdk-codegen-scripts bumped from 21.5.19 to 21.5.20 * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/extension-api-explorer: 22.21.20</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/api-explorer bumped from 0.9.62 to 0.9.63 * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1 * @looker/extension-utils bumped from 0.1.39 to 0.1.40 * @looker/run-it bumped from 0.9.62 to 0.9.63 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/extension-playground: 1.0.20</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/extension-tile-playground: 1.1.7</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/extension-utils: 0.1.40</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/hackathon: 22.21.22</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/extension-sdk-react bumped from 24.12.0 to 24.12.1 * @looker/extension-utils bumped from 0.1.39 to 0.1.40 * @looker/sdk bumped from 24.12.0 to 24.12.1 * @looker/wholly-artifact bumped from 0.1.20 to 0.1.21 </details> <details><summary>@looker/run-it: 0.9.63</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-utils bumped from 0.1.39 to 0.1.40 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/sdk-codegen-scripts: 21.5.20</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/wholly-artifact: 0.1.21</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 * devDependencies * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>@looker/wholly-sheet: 0.5.59</summary> ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 * devDependencies * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>sdk-codegen-all: 24.12.1</summary> ## [24.12.1](sdk-codegen-all-v24.12.0...sdk-codegen-all-v24.12.1) (2024-07-29) ### Bug Fixes * **python SDKError:** Fixed SDKError __str__ ([#1480](#1480)) ([#1486](#1486)) ([d8907fe](d8907fe)) </details> <details><summary>looker_sdk: 24.12.1</summary> ## [24.12.1](looker_sdk-v24.12.0...looker_sdk-v24.12.1) (2024-07-29) ### Bug Fixes * **python SDKError:** Fixed SDKError __str__ ([#1480](#1480)) ([#1486](#1486)) ([d8907fe](d8907fe)) </details> <details><summary>embed-components: 24.12.1</summary> ## [24.12.1](embed-components-v24.12.0...embed-components-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **embed-components:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/embed-services bumped from 24.12.0 to 24.12.1 * @looker/sdk bumped from 24.12.0 to 24.12.1 * devDependencies * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>embed-services: 24.12.1</summary> ## [24.12.1](embed-services-v24.12.0...embed-services-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **embed-services:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 * devDependencies * @looker/sdk-node bumped from 24.12.0 to 24.12.1 </details> <details><summary>extension-sdk: 24.12.1</summary> ## [24.12.1](extension-sdk-v24.12.0...extension-sdk-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **extension-sdk:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>extension-sdk-react: 24.12.1</summary> ## [24.12.1](extension-sdk-react-v24.12.0...extension-sdk-react-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **extension-sdk-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/extension-sdk bumped from 24.12.0 to 24.12.1 * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> <details><summary>sdk: 24.12.1</summary> ## [24.12.1](sdk-v24.12.0...sdk-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **sdk:** Synchronize undefined versions </details> <details><summary>sdk-node: 24.12.1</summary> ## [24.12.1](sdk-node-v24.12.0...sdk-node-v24.12.1) (2024-07-29) ### Miscellaneous Chores * **sdk-node:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @looker/sdk bumped from 24.12.0 to 24.12.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

drstrangelooker requested a review from a team as a code owner July 29, 2024 20:44

drstrangelooker requested a review from jkaster July 29, 2024 20:53

jkaster approved these changes Jul 29, 2024

View reviewed changes

drstrangelooker merged commit d8907fe into main Jul 29, 2024
24 checks passed

drstrangelooker deleted the python_SDKError_str_fix-internal branch July 29, 2024 21:13

looker-open-source-automation-bot mentioned this pull request Jul 29, 2024

chore: release main #1487

Merged

jeremytchang mentioned this pull request Aug 26, 2024

python SDKError __str__ bug #1479

Closed

JCPistell pushed a commit that referenced this pull request Aug 29, 2024

fix(python SDKError): Fixed SDKError __str__ (#1480) (#1486)

33fa834

Co-authored-by: syvokobylka <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(python SDKError): Fixed SDKError str (#1480) #1486

fix(python SDKError): Fixed SDKError str (#1480) #1486

drstrangelooker commented Jul 29, 2024

drstrangelooker commented Jul 29, 2024

github-actions bot commented Jul 29, 2024

fix(python SDKError): Fixed SDKError __str__ (#1480) #1486

fix(python SDKError): Fixed SDKError __str__ (#1480) #1486

Conversation

drstrangelooker commented Jul 29, 2024

drstrangelooker commented Jul 29, 2024

github-actions bot commented Jul 29, 2024

Python Tests

fix(python SDKError): Fixed SDKError str (#1480) #1486

fix(python SDKError): Fixed SDKError str (#1480) #1486