perf: reduce package bundle size

Author: luin

lib/commander.js

@@ -36,7 +36,7 @@ commands.push('sentinel');
  * @public
  */
 Commander.prototype.getBuiltinCommands = function () {
-  return _.clone(commands);
+  return commands.slice(0);
 };
 
 /**

lib/redis.js

@@ -366,7 +366,7 @@ Redis.prototype.end = function () {
  * @public
  */
 Redis.prototype.duplicate = function (override) {
-  return new Redis(Object.assign(_.cloneDeep(this.options), override || {}));
+  return new Redis(Object.assign({}, this.options, override || {}));
 };
 
 /**

lib/utils/lodash.js

@@ -5,12 +5,9 @@ exports.pick = require('lodash.pick');
 exports.defaults = require('lodash.defaults');
 exports.noop = function () {};
 exports.difference = require('lodash.difference');
-exports.clone = require('lodash.clone');
 exports.sample = require('lodash.sample');
 exports.flatten = require('lodash.flatten');
-exports.bind = require('lodash.bind');
 exports.isEmpty = require('lodash.isempty');
 exports.values = require('lodash.values');
 exports.shuffle = require('lodash.shuffle');
 exports.partial = require('lodash.partial');
-exports.cloneDeep = require('lodash.clonedeep');

package-lock.json

@@ -12,7 +12,7 @@
     "test:cov": "NODE_ENV=test node ./node_modules/istanbul/lib/cli.js cover --preserve-comments ./node_modules/mocha/bin/_mocha -- -r ts-node/register -R spec --exit",
     "build": "rm -rf built && tsc",
     "generate-docs": "jsdoc2md lib/redis.js lib/cluster/index.js lib/commander.js > API.md",
-    "prepublish": "npm run build && npm test",
+    "prepublishOnly": "npm run build && npm test",
     "bench": "matcha benchmarks/*.js"
   },
   "repository": {
@@ -32,9 +32,6 @@
     "debug": "^3.1.0",
     "denque": "^1.1.0",
     "flexbuffer": "0.0.6",
-    "lodash.bind": "^4.2.1",
-    "lodash.clone": "^4.5.0",
-    "lodash.clonedeep": "^4.5.0",
     "lodash.defaults": "^4.2.0",
     "lodash.difference": "^4.5.0",
     "lodash.flatten": "^4.4.0",

package.json

@@ -0,0 +1,10 @@
+'use strict';
+
+describe('duplicate', () => {
+  it('clone the options', () => {
+    var redis = new Redis()
+    var duplicatedRedis = redis.duplicate()
+    redis.options.port = 1234
+    expect(duplicatedRedis.options.port).to.eql(6379)
+  });
+});

test/functional/duplicate.js

@@ -3,6 +3,16 @@
 var Commander = require('../../lib/commander');
 
 describe('Commander', function () {
+  describe('#getBuiltinCommands()', () => {
+    it('returns a new copy of commands', () => {
+      const c = new Commander()
+      const commands = c.getBuiltinCommands()
+      commands.unshift('abc')
+      const commandsNew = c.getBuiltinCommands()
+      expect(commands.slice(1)).to.eql(commandsNew)
+    })
+  })
+
   it('should pass the correct arguments', function () {
     stub(Commander.prototype, 'sendCommand', function (command) {
       return command;