fix get_boolean_array

lukec · lukec · commit cbda59c68507 · 2007-02-06T15:42:04.000Z
git-svn-id: http://svn.openqa.org/svn/selenium-rc/trunk/clients/perl@1742 0891141a-5dea-0310-ad27-ebc607f31677
diff --git a/Changes b/Changes
@@ -2,6 +2,7 @@ Revision history for Perl extension Test::WWW::Selenium.
 
 1.12 -
  - refactor unit tests to use Test::Mock::LWP
+ - fix bug in get_boolean_array - thanks to Ilya Averyanov
 
 1.11 - Thu Jan  4 19:53:18 PST 2007
  - don't stop a stopped session
diff --git a/todo.txt b/todo.txt
@@ -1,5 +1,7 @@
 - bundle test modules with distribution M::I::Bundle
 
+- add tests for get_boolean_array()
+
 - WWW::Selenium
   - check that browser_url is sane
 
diff --git a/util/create_www_selenium.pl b/util/create_www_selenium.pl
@@ -70,7 +70,7 @@ package WWW::Selenium;
 use strict;
 use warnings;
 
-our $VERSION = '0.91';
+our $VERSION = '0.911';
 
 =head1 NAME
 
@@ -359,7 +359,7 @@ sub get_boolean_array {
             next;
         }
         if ($result[$i] eq "false") {
-            push (@boolarr, 1);
+            push (@boolarr, 0);
             next;
         }
         die "result is neither 'true' nor 'false': ". $result[$i];

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ package WWW::Selenium;`
`70`	`70`	`use strict;`
`71`	`71`	`use warnings;`
`72`	`72`
`73`		`-our $VERSION = '0.91';`
	`73`	`+our $VERSION = '0.911';`
`74`	`74`
`75`	`75`	`=head1 NAME`
`76`	`76`
`@@ -359,7 +359,7 @@ sub get_boolean_array {`
`359`	`359`	`next;`
`360`	`360`	`}`
`361`	`361`	`if ($result[$i] eq "false") {`
`362`		`- push (@boolarr, 1);`
	`362`	`+ push (@boolarr, 0);`
`363`	`363`	`next;`
`364`	`364`	`}`
`365`	`365`	`die "result is neither 'true' nor 'false': ". $result[$i];`