Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 添加快捷键+更完整的辅助线提示 #148

Merged
merged 7 commits into from
Apr 17, 2020

Conversation

shihongzhi
Copy link
Contributor

@shihongzhi shihongzhi commented Apr 16, 2020

本PR主要包含两个功能:

  1. 为编辑器的操作栏部分操作添加常用快捷键, 同时删除无用的文本代码
  2. 添加更完整的辅助线提示。之前的辅助线只提示元素的left和top边,现在添加其他四条边的提示。四条边分别是right, bottom, midx, midy

@todo
Copy link

todo bot commented Apr 16, 2020

如果是Point移动的情况下,应该是修改width

// TODO 如果是Point移动的情况下,应该是修改width
this.setElementPosition({ left: x - (v - eleft) })
this.drawVLine(x)
hasVLine = true
}
})


This comment was generated by todo based on a TODO comment in d66a7ea in #148. cc @shihongzhi.

Copy link
Owner

@ly525 ly525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非常感谢,辛苦了 👍!
参考线的一些内容,我提了一些建议,你看下是否可用,建议适当修改,增加代码相关变量的语义化。
其他内容,后面我可以继续补充

@ly525 ly525 changed the title 添加快捷键+更完整的辅助线提示 feat: 添加快捷键+更完整的辅助线提示 Apr 17, 2020
@ly525 ly525 merged commit d039dcb into ly525:dev Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants