-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests fail under node 6.10.1 #4471
Comments
Release notes: https://nodejs.org/en/blog/release/v6.10.1/ |
This was a latent bug exposed by node fixing nodejs/node#6287, which in turn fixes jsdom/jsdom#1622, which we are implicitly relying on due to the order of actions in
(2) and (3) should occur in the opposite order. It happened to work in prior version of node because (1) didn't actually delete our custom properties due to the above linked issues. PR incoming. |
...turns out fixing that fixes one issue, but there are others. Stay tuned. |
Unit tests which pass under 6.10.0 are failing on node 6.10.1, released today. The first failing test is:
Failed job: https://circleci.com/gh/mapbox/mapbox-gl-js/7292.
#4470 pins to 6.10.0 temporarily so that we can continue working while this is investigated.
The text was updated successfully, but these errors were encountered: