Skip to content

Commit ba6e90d

Browse files
committed
Split lint and test requirements into two separate files
1 parent 4d1ba8a commit ba6e90d

File tree

4 files changed

+32
-30
lines changed

4 files changed

+32
-30
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ since version 1.3.0.
77

88
## [Unreleased]
99

10+
### Changed
11+
- Split lint and test requirements into two separate files.
12+
1013
### Fixed
1114
- Fix setup encoding comment to deal with corner case under PowerShell.
1215
- Enforce dependency `numpy >= 1.21` for Python >= 3.7 due to `numpy`
+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
unittest2; python_version <= "3.9"
2+
3+
flake8 >= 2.6, < 3.0; python_version == "2.6"
4+
flake8 >= 2.6, < 4.0; python_version == "2.7"
5+
flake8 >= 2.6, < 3.0; python_version == "3.2"
6+
flake8 >= 2.6, < 3.0; python_version == "3.3"
7+
flake8 >= 2.6, < 3.9; python_version == "3.4"
8+
flake8 >= 2.6, < 4.1; python_version >= "3.5"
9+
10+
astroid >= 1.6, < 2.0; python_version == "2.7"
11+
astroid >= 2.4, < 3.0; python_version >= "3.5"
12+
pylint >= 1.9, < 2.0; python_version == "2.7"
13+
pylint >= 2.6, < 3.0; python_version >= "3.5"

packages/basemap/requirements-dev.txt packages/basemap/requirements-test.txt

+3-14
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,12 @@
1-
flake8 >= 2.6, < 3.0; python_version == "2.6"
2-
flake8 >= 2.6, < 4.0; python_version == "2.7"
3-
flake8 >= 2.6, < 3.0; python_version == "3.2"
4-
flake8 >= 2.6, < 3.0; python_version == "3.3"
5-
flake8 >= 2.6, < 3.9; python_version == "3.4"
6-
flake8 >= 2.6, < 4.1; python_version >= "3.5"
7-
8-
astroid >= 1.6, < 2.0; python_version == "2.7"
9-
astroid >= 2.4, < 3.0; python_version >= "3.5"
10-
pylint >= 1.9, < 2.0; python_version == "2.7"
11-
pylint >= 2.6, < 3.0; python_version >= "3.5"
12-
13-
unittest2; python_version < "3.10"
1+
unittest2; python_version <= "3.9"
142

3+
typing >= 3.5, < 3.11; python_version == "3.4"
154
pytest >= 3.2, < 3.3; python_version == "2.6"
165
pytest >= 3.2, < 5.0; python_version == "2.7"
176
pytest >= 2.9, < 3.0; python_version == "3.2"
187
pytest >= 3.2, < 3.3; python_version == "3.3"
198
pytest >= 3.2, < 5.0; python_version == "3.4"
20-
pytest >= 3.2, < 6.3; python_version == "3.5"
9+
pytest >= 3.2, < 6.2; python_version == "3.5"
2110
pytest >= 6.2.5, < 6.3; python_version >= "3.6"
2211

2312
coverage >= 3.7, < 4.0; python_version == "3.2"

packages/basemap/setup.py

+13-16
Original file line numberDiff line numberDiff line change
@@ -146,25 +146,20 @@ def _default_to_zip(self):
146146
]
147147

148148
# Define all the different requirements.
149-
dev_requires = get_content("requirements-dev.txt", splitlines=True)
150-
doc_requires = get_content("requirements-doc.txt", splitlines=True)
151149
setup_requires = get_content("requirements-setup.txt", splitlines=True)
152150
install_requires = get_content("requirements.txt", splitlines=True)
153151
if sys.version_info[:2] == (3, 2):
154152
# Hack for Python 3.2 because pip < 8 cannot handle version markers.
155-
marker = '; python_version == "3.2"'
156-
dev_requires = [
157-
item.replace(marker, "") for item in dev_requires
158-
if item.endswith(marker) or "python_version" not in item]
159-
doc_requires = [
160-
item.replace(marker, "") for item in doc_requires
161-
if item.endswith(marker) or "python_version" not in item]
153+
marker1 = '; python_version == "3.2"'
154+
marker2 = '; python_version >= "2.7"'
162155
setup_requires = [
163-
item.replace(marker, "") for item in setup_requires
164-
if item.endswith(marker) or "python_version" not in item]
156+
item.replace(marker1, "").replace(marker2, "") for item in setup_requires
157+
if item.endswith(marker1) or item.endswith(marker2)
158+
or "python_version" not in item]
165159
install_requires = [
166-
item.replace(marker, "") for item in install_requires
167-
if item.endswith(marker) or "python_version" not in item]
160+
item.replace(marker1, "").replace(marker2, "") for item in install_requires
161+
if item.endswith(marker1) or item.endswith(marker2)
162+
or "python_version" not in item]
168163

169164
setup(**{
170165
"name":
@@ -228,10 +223,12 @@ def _default_to_zip(self):
228223
"install_requires":
229224
install_requires,
230225
"extras_require": {
231-
"dev":
232-
dev_requires,
233226
"doc":
234-
doc_requires,
227+
get_content("requirements-doc.txt", splitlines=True),
228+
"lint":
229+
get_content("requirements-lint.txt", splitlines=True),
230+
"test":
231+
get_content("requirements-test.txt", splitlines=True),
235232
},
236233
"cmdclass": {
237234
"sdist": basemap_sdist,

0 commit comments

Comments
 (0)