Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib < 3.7 requirement? #573

Closed
jameswilburlewis opened this issue May 3, 2023 · 3 comments
Closed

matplotlib < 3.7 requirement? #573

jameswilburlewis opened this issue May 3, 2023 · 3 comments

Comments

@jameswilburlewis
Copy link

I'm glad to see basemap is still being developed! Are there any plans to support more recent versions of matplotlib? We recently patched some code to remove a reference to legendHandles (now deprecated and removed from matplotlib), but this caused a version conflict with matplotlib<3.7 from basemap, and matplotlib >= 3.7 for legend_handles. We were able to resolve the conflict with a version check, but it would be great if basemap didn't have the upper limit on matplotlib versions.

@molinav
Copy link
Member

molinav commented May 3, 2023

Hi @jameswilburlewis! In principle it should be no problem to upgrade the matplotlib requirements. The upper pin is there based on the latest matplotlib version at the time the latest basemap was released.

I can take a look to the requirements files in the following days to keep them up to date and release a new patch version for basemap.

@molinav
Copy link
Member

molinav commented May 4, 2023

The basemap hotfix release 1.3.7 is now available on PyPI. I will also trigger a rebuild for the conda-forge package soon.

I upgraded several version pins apart from matplotlib, you can see all the changes here: v1.3.6...v1.3.7.

@molinav
Copy link
Member

molinav commented May 5, 2023

@jameswilburlewis Finally basemap 1.3.7 is available both on PyPI and conda-forge for Windows and GNU/Linux, with all the requirements up to date, this should mitigate your issues in spedas/pyspedas#461.

If something is still not working for you, feel free to reopen the issue and I will see what I can do.

@molinav molinav closed this as completed May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants