From ee85b2bb830040d5e7fb951f6cd51a770f7de1a7 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Mon, 24 Feb 2025 09:45:41 +0100 Subject: [PATCH 1/7] add linter to pre-commit --- .pre-commit-config.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .pre-commit-config.yaml diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml new file mode 100644 index 00000000..18191ea7 --- /dev/null +++ b/.pre-commit-config.yaml @@ -0,0 +1,16 @@ +ci: + autofix_commit_msg: | + [pre-commit.ci] auto fixes from pre-commit.com hooks + + for more information, see https://pre-commit.ci + autofix_prs: false + autoupdate_commit_msg: '[pre-commit.ci] pre-commit autoupdate' + autoupdate_schedule: monthly + skip: [] + submodules: false + +repos: + - repo: https://github.com/psf/black-pre-commit-mirror + rev: 25.1.0 + hooks: + - id: black \ No newline at end of file From 9418de349af9b25e439425421e5a40e268afc8a6 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Mon, 24 Feb 2025 09:49:11 +0100 Subject: [PATCH 2/7] add flake8 --- .pre-commit-config.yaml | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 18191ea7..469909fb 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,16 +1,20 @@ ci: - autofix_commit_msg: | - [pre-commit.ci] auto fixes from pre-commit.com hooks + autofix_commit_msg: | + [pre-commit.ci] auto fixes from pre-commit.com hooks - for more information, see https://pre-commit.ci - autofix_prs: false - autoupdate_commit_msg: '[pre-commit.ci] pre-commit autoupdate' - autoupdate_schedule: monthly - skip: [] - submodules: false + for more information, see https://pre-commit.ci + autofix_prs: false + autoupdate_commit_msg: "[pre-commit.ci] pre-commit autoupdate" + autoupdate_schedule: monthly + skip: [] + submodules: false repos: - repo: https://github.com/psf/black-pre-commit-mirror rev: 25.1.0 hooks: - - id: black \ No newline at end of file + - id: black + - repo: https://github.com/pycqa/flake8 + rev: 7.0.0 + hooks: + - id: flake8 From 13d87c15a70cb04ef67625813c4d5a596e2efdb8 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Mon, 24 Feb 2025 09:57:47 +0100 Subject: [PATCH 3/7] mv precommit to basemap --- packages/basemap/.pre-commit-config.yaml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 packages/basemap/.pre-commit-config.yaml diff --git a/packages/basemap/.pre-commit-config.yaml b/packages/basemap/.pre-commit-config.yaml new file mode 100644 index 00000000..469909fb --- /dev/null +++ b/packages/basemap/.pre-commit-config.yaml @@ -0,0 +1,20 @@ +ci: + autofix_commit_msg: | + [pre-commit.ci] auto fixes from pre-commit.com hooks + + for more information, see https://pre-commit.ci + autofix_prs: false + autoupdate_commit_msg: "[pre-commit.ci] pre-commit autoupdate" + autoupdate_schedule: monthly + skip: [] + submodules: false + +repos: + - repo: https://github.com/psf/black-pre-commit-mirror + rev: 25.1.0 + hooks: + - id: black + - repo: https://github.com/pycqa/flake8 + rev: 7.0.0 + hooks: + - id: flake8 From ceb662b0a6251bd2ec123cc8630403129d720a3b Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Mon, 24 Feb 2025 09:57:58 +0100 Subject: [PATCH 4/7] add requirements to setup --- packages/basemap/requirements-setup.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/basemap/requirements-setup.txt b/packages/basemap/requirements-setup.txt index 6f39a1a0..dad8a782 100644 --- a/packages/basemap/requirements-setup.txt +++ b/packages/basemap/requirements-setup.txt @@ -1,2 +1,3 @@ cython >= 0.29, < 3.1; python_version >= "3.3" or python_version < "3.0" cython >= 0.26, < 0.27; python_version == "3.2" +precommit From 66b74bef0263e2aa3e597b5ea66acab3791c6c2f Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Mon, 24 Feb 2025 10:03:39 +0100 Subject: [PATCH 5/7] typo --- .pre-commit-config.yaml | 20 -------------------- packages/basemap/requirements-setup.txt | 2 +- 2 files changed, 1 insertion(+), 21 deletions(-) delete mode 100644 .pre-commit-config.yaml diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml deleted file mode 100644 index 469909fb..00000000 --- a/.pre-commit-config.yaml +++ /dev/null @@ -1,20 +0,0 @@ -ci: - autofix_commit_msg: | - [pre-commit.ci] auto fixes from pre-commit.com hooks - - for more information, see https://pre-commit.ci - autofix_prs: false - autoupdate_commit_msg: "[pre-commit.ci] pre-commit autoupdate" - autoupdate_schedule: monthly - skip: [] - submodules: false - -repos: - - repo: https://github.com/psf/black-pre-commit-mirror - rev: 25.1.0 - hooks: - - id: black - - repo: https://github.com/pycqa/flake8 - rev: 7.0.0 - hooks: - - id: flake8 diff --git a/packages/basemap/requirements-setup.txt b/packages/basemap/requirements-setup.txt index dad8a782..5a87e2ba 100644 --- a/packages/basemap/requirements-setup.txt +++ b/packages/basemap/requirements-setup.txt @@ -1,3 +1,3 @@ cython >= 0.29, < 3.1; python_version >= "3.3" or python_version < "3.0" cython >= 0.26, < 0.27; python_version == "3.2" -precommit +pre-commit From e1f8819e0f26a9169fecfae923bc765884c5100f Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Mon, 24 Feb 2025 10:07:06 +0100 Subject: [PATCH 6/7] set src --- packages/basemap/.pre-commit-config.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/basemap/.pre-commit-config.yaml b/packages/basemap/.pre-commit-config.yaml index 469909fb..c47d958d 100644 --- a/packages/basemap/.pre-commit-config.yaml +++ b/packages/basemap/.pre-commit-config.yaml @@ -14,7 +14,9 @@ repos: rev: 25.1.0 hooks: - id: black + files: ^src/ - repo: https://github.com/pycqa/flake8 rev: 7.0.0 hooks: - id: flake8 + files: ^src/ From 151e5aa76cbc6a99d29f42e2e506dcc958e7eff6 Mon Sep 17 00:00:00 2001 From: cvanelteren Date: Mon, 24 Feb 2025 10:21:20 +0100 Subject: [PATCH 7/7] mv pre-commit to the top --- .../.pre-commit-config.yaml => .pre-commit-config.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) rename packages/basemap/.pre-commit-config.yaml => .pre-commit-config.yaml (67%) diff --git a/packages/basemap/.pre-commit-config.yaml b/.pre-commit-config.yaml similarity index 67% rename from packages/basemap/.pre-commit-config.yaml rename to .pre-commit-config.yaml index c47d958d..283d714f 100644 --- a/packages/basemap/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,7 +1,6 @@ ci: autofix_commit_msg: | [pre-commit.ci] auto fixes from pre-commit.com hooks - for more information, see https://pre-commit.ci autofix_prs: false autoupdate_commit_msg: "[pre-commit.ci] pre-commit autoupdate" @@ -10,13 +9,14 @@ ci: submodules: false repos: - - repo: https://github.com/psf/black-pre-commit-mirror + - repo: https://github.com/psf/black rev: 25.1.0 hooks: - id: black - files: ^src/ + exclude: ^(examples/|packages/basemap_data/|packages/basemap_data_hires/) + - repo: https://github.com/pycqa/flake8 rev: 7.0.0 hooks: - id: flake8 - files: ^src/ + exclude: ^(examples/|packages/basemap_data/|packages/basemap_data_hires/)