tls: handle ipv6 addresses in host-header

mattiasholmlund · mattiasholmlund · commit 0d19c2045fc7 · 2017-10-10T14:56:21.000+02:00
When an http-client requests a url with the hostname specified as an IPv6 address, the Host: header will have the following format: Host: [::1]:3000 The servername in this case should be '::1'. Fixes: nodejs#14736
diff --git a/lib/_http_agent.js b/lib/_http_agent.js
@@ -157,7 +157,12 @@ Agent.prototype.addRequest = function addRequest(req, options, port/*legacy*/,
     options.servername = options.host;
     const hostHeader = req.getHeader('host');
     if (hostHeader) {
-      options.servername = hostHeader.replace(/:.*$/, '');
+      // abc => abc
+      // abc:123 => abc
+      // [::1] => ::1
+      // [::1]:123 => ::1
+      options.servername = hostHeader.replace(/:[^\]]+$/, '')
+        .replace(/^\[(.*)\]$/, '$1');
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,12 @@ Agent.prototype.addRequest = function addRequest(req, options, port/legacy/,`
`157`	`157`	`options.servername = options.host;`
`158`	`158`	`const hostHeader = req.getHeader('host');`
`159`	`159`	`if (hostHeader) {`
`160`		`- options.servername = hostHeader.replace(/:.*$/, '');`
	`160`	`+ // abc => abc`
	`161`	`+ // abc:123 => abc`
	`162`	`+ // [::1] => ::1`
	`163`	`+ // [::1]:123 => ::1`
	`164`	`+ options.servername = hostHeader.replace(/:[^\]]+$/, '')`
	`165`	`+ .replace(/^\[(.*)\]$/, '$1');`
`161`	`166`	`}`
`162`	`167`	`}`
`163`	`168`