Skip to content

Commit 03708c5

Browse files
committed
build: Remove --install-links from playground build
This is no longer needed; the npm change was reverted in `9.4.0`: npm/cli#6142
1 parent 3ca15d5 commit 03708c5

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

Taskfile.yml

+8-8
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,8 @@ tasks:
162162
{{ range $dep := (.brew_dependencies | trim | splitLines) -}}
163163
[ -n "$(which {{ $dep }})" ]
164164
{{ end -}}
165-
- "[ $(npm -v | cut -d. -f1) -ge 9 ]"
165+
- |
166+
[ "$(npm -v | awk -F. '{print ($1 > 9 || ($1 == 9 && $2 > 4)) ? 0 : 1}')" -eq 0 ]
166167
silent: true
167168
cmds:
168169
- cmd: |
@@ -172,7 +173,9 @@ tasks:
172173
173174
{{ .brew_dependencies }}
174175
175-
These aren't required for initial PRQL development, but they are required for some of the tests.
176+
...or alternatively that npm < 9.4
177+
178+
These aren't required for initial PRQL development, but they are required for some of the extras.
176179
177180
Install them with:
178181
@@ -292,7 +295,7 @@ tasks:
292295
# Must set `install-links=false` in the playground's `npm install` to
293296
# install prql-js as the regular dependency, instead of creating a
294297
# symlink. Refer to https://github.com/PRQL/prql/pull/1296.
295-
- cd playground && npm install --install-links=false
298+
- cd playground && npm install
296299
- cd playground && npm run build
297300
# We place the playground app in a nested path, because we want to use
298301
# prql-lang.org/playground with an iframe containing the playground.
@@ -347,7 +350,7 @@ tasks:
347350
desc: Build & serve the playground.
348351
dir: web/playground
349352
cmds:
350-
- npm install --install-links=false
353+
- npm install
351354
- npm start
352355

353356
run-playground-cached:
@@ -362,13 +365,10 @@ tasks:
362365
# Use task's sources/generates to see if checksums of
363366
# node_modules directory have changed since package.json was updated
364367

365-
# Use `npm install --install-links=false` to install prql-js
366-
# as the regular dependency, instead of creating a
367-
# symlink. Refer to https://github.com/PRQL/prql/pull/1296.
368368
desc: Check to see if package.json has changed since we ran npm install
369369
dir: web/playground
370370
cmds:
371-
- npm install --install-links=false
371+
- npm install
372372
sources:
373373
- package.json
374374
generates:

web/playground/package-lock.json

+14-14
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)