Skip to content

Commit e03afe2

Browse files
committedAug 3, 2022
Solving bugs from core_plugin.
1 parent 0e2f483 commit e03afe2

File tree

2 files changed

+36
-8
lines changed

2 files changed

+36
-8
lines changed
 

‎source/cli/plugins/core_plugin/CMakeLists.txt

+34-7
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,32 @@ generate_export_header(${target}
101101
# Project options
102102
#
103103

104+
set(CUSTOM_OUTPUT_DIRECTORY "${PROJECT_OUTPUT_DIR}/plugins/${target}")
105+
104106
set_target_properties(${target}
105107
PROPERTIES
106108
${DEFAULT_PROJECT_OPTIONS}
107109
FOLDER "${IDE_FOLDER}"
108110
BUNDLE $<$<BOOL:${APPLE}>:$<$<VERSION_GREATER:${PROJECT_OS_VERSION},8>>>
111+
112+
# Define custom build output directory
113+
LIBRARY_OUTPUT_DIRECTORY "${CUSTOM_OUTPUT_DIRECTORY}"
114+
LIBRARY_OUTPUT_DIRECTORY_DEBUG "${CUSTOM_OUTPUT_DIRECTORY}"
115+
LIBRARY_OUTPUT_DIRECTORY_RELEASE "${CUSTOM_OUTPUT_DIRECTORY}"
116+
LIBRARY_OUTPUT_DIRECTORY_RELWITHDEBINFO "${CUSTOM_OUTPUT_DIRECTORY}"
117+
LIBRARY_OUTPUT_DIRECTORY_MINSIZEREL "${CUSTOM_OUTPUT_DIRECTORY}"
118+
119+
RUNTIME_OUTPUT_DIRECTORY "${CUSTOM_OUTPUT_DIRECTORY}"
120+
RUNTIME_OUTPUT_DIRECTORY_DEBUG "${CUSTOM_OUTPUT_DIRECTORY}"
121+
RUNTIME_OUTPUT_DIRECTORY_RELEASE "${CUSTOM_OUTPUT_DIRECTORY}"
122+
RUNTIME_OUTPUT_DIRECTORY_RELWITHDEBINFO "${CUSTOM_OUTPUT_DIRECTORY}"
123+
RUNTIME_OUTPUT_DIRECTORY_MINSIZEREL "${CUSTOM_OUTPUT_DIRECTORY}"
124+
125+
ARCHIVE_OUTPUT_DIRECTORY "${CUSTOM_OUTPUT_DIRECTORY}"
126+
ARCHIVE_OUTPUT_DIRECTORY_DEBUG "${CUSTOM_OUTPUT_DIRECTORY}"
127+
ARCHIVE_OUTPUT_DIRECTORY_RELEASE "${CUSTOM_OUTPUT_DIRECTORY}"
128+
ARCHIVE_OUTPUT_DIRECTORY_RELWITHDEBINFO "${CUSTOM_OUTPUT_DIRECTORY}"
129+
ARCHIVE_OUTPUT_DIRECTORY_MINSIZEREL "${CUSTOM_OUTPUT_DIRECTORY}"
109130
)
110131

111132
#
@@ -188,21 +209,27 @@ target_link_libraries(${target}
188209
# Define dependencies
189210
#
190211

212+
# Copy metacall.json
213+
add_custom_target(${target}-create-plugin-dir ALL
214+
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
215+
COMMAND ${CMAKE_COMMAND} -E make_directory ${PROJECT_OUTPUT_DIR}/plugins/core_plugin
216+
COMMAND ${CMAKE_COMMAND} -E copy ${source_path}/metacall.json ${PROJECT_OUTPUT_DIR}/plugins/core_plugin
217+
)
218+
219+
set_target_properties(${target}-create-plugin-dir
220+
PROPERTIES
221+
FOLDER "${IDE_FOLDER}"
222+
)
223+
191224
add_dependencies(${target}
225+
${target}-create-plugin-dir
192226
plugin_extension
193227
)
194228

195229
#
196230
# Deployment
197231
#
198232

199-
# Copy metacall-*.json
200-
add_custom_target(${target}-create-plugin-dir ALL
201-
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
202-
COMMAND ${CMAKE_COMMAND} -E make_directory ${PROJECT_OUTPUT_DIR}/plugins/core_plugin
203-
COMMAND ${CMAKE_COMMAND} -E copy ${source_path}/metacall.json ${PROJECT_OUTPUT_DIR}/plugins/core_plugin
204-
)
205-
206233
# Library
207234
install(TARGETS ${target}
208235
EXPORT "${target}-export" COMPONENT dev

‎source/tests/metacall_plugin_extension_destroy_order_test/CMakeLists.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Check if this loader is enabled
2-
if(NOT OPTION_BUILD_LOADERS OR NOT OPTION_BUILD_LOADERS_EXT OR NOT OPTION_BUILD_EXTENSIONS)
2+
if(NOT OPTION_BUILD_LOADERS OR NOT OPTION_BUILD_LOADERS_EXT OR NOT OPTION_BUILD_EXTENSIONS OR NOT OPTION_BUILD_CLI)
33
return()
44
endif()
55

@@ -130,6 +130,7 @@ add_test(NAME ${target}
130130
add_dependencies(${target}
131131
ext_loader
132132
plugin_extension
133+
core_plugin # Requires core_plugin (from CLI) for reproducing it
133134
)
134135

135136
#

0 commit comments

Comments
 (0)