Merge pull request DefinitelyTyped#16025 from slawiko/16023-cookiejs-renaming

16023: creates second types folder for those, who uses npm package co…

Author: aozgaa

types/cookiejs/cookiejs-tests.ts types/cookie_js/cookie_js-tests.ts

@@ -1,8 +1,4 @@
-
-
-// Based on https://github.com/js-coder/cookie.js/blob/gh-pages/tests/spec.js
-
-import cookie = require("cookiejs");
+import cookie = require("cookie_js");
 
 cookie.set({a: '1', b: '2', c: '3'});
 

types/cookiejs/index.d.ts types/cookie_js/index.d.ts

@@ -1,13 +1,18 @@
-// Type definitions for cookie.js v1.2.2
+// Type definitions for cookie_js v1.2.2
 // Project: https://github.com/florian/cookie.js
-// Definitions by: Boltmade <https://github.com/Boltmade>
+// Definitions by: slawiko <https://github.com/slawiko>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
+
+declare module 'cookie_js' {
+  export = cookie;
+}
+
 /**
- * Shortcut for cookie.get()
+ * https://github.com/DefinitelyTyped/DefinitelyTyped/pull/16025#issuecomment-295784660
  */
-
-export = cookie;
-export as namespace cookie;
+declare module 'cookiejs' {
+  export = cookie;
+}
 
 declare function cookie(key : string, fallback?: string) : string;
 declare function cookie(keys : string[], fallback?: string) : string;

types/cookiejs/tsconfig.json types/cookie_js/tsconfig.json

@@ -6,7 +6,7 @@
         ],
         "noImplicitAny": true,
         "noImplicitThis": true,
-        "strictNullChecks": false,
+        "strictNullChecks": true,
         "baseUrl": "../",
         "typeRoots": [
             "../"
@@ -17,6 +17,6 @@
     },
     "files": [
         "index.d.ts",
-        "cookiejs-tests.ts"
+        "cookie_js-tests.ts"
     ]
-}
+}