|
5 | 5 | #include "src/crankshaft/hydrogen-gvn.h"
|
6 | 6 |
|
7 | 7 | #include "src/crankshaft/hydrogen.h"
|
| 8 | +#include "src/list.h" |
| 9 | +#include "src/list-inl.h" |
8 | 10 | #include "src/v8.h"
|
9 | 11 |
|
10 | 12 | namespace v8 {
|
@@ -655,19 +657,23 @@ SideEffects
|
655 | 657 | HGlobalValueNumberingPhase::CollectSideEffectsOnPathsToDominatedBlock(
|
656 | 658 | HBasicBlock* dominator, HBasicBlock* dominated) {
|
657 | 659 | SideEffects side_effects;
|
658 |
| - for (int i = 0; i < dominated->predecessors()->length(); ++i) { |
659 |
| - HBasicBlock* block = dominated->predecessors()->at(i); |
660 |
| - if (dominator->block_id() < block->block_id() && |
661 |
| - block->block_id() < dominated->block_id() && |
662 |
| - !visited_on_paths_.Contains(block->block_id())) { |
663 |
| - visited_on_paths_.Add(block->block_id()); |
664 |
| - side_effects.Add(block_side_effects_[block->block_id()]); |
665 |
| - if (block->IsLoopHeader()) { |
666 |
| - side_effects.Add(loop_side_effects_[block->block_id()]); |
| 660 | + List<HBasicBlock*> blocks; |
| 661 | + for (;;) { |
| 662 | + for (int i = 0; i < dominated->predecessors()->length(); ++i) { |
| 663 | + HBasicBlock* block = dominated->predecessors()->at(i); |
| 664 | + if (dominator->block_id() < block->block_id() && |
| 665 | + block->block_id() < dominated->block_id() && |
| 666 | + !visited_on_paths_.Contains(block->block_id())) { |
| 667 | + visited_on_paths_.Add(block->block_id()); |
| 668 | + side_effects.Add(block_side_effects_[block->block_id()]); |
| 669 | + if (block->IsLoopHeader()) { |
| 670 | + side_effects.Add(loop_side_effects_[block->block_id()]); |
| 671 | + } |
| 672 | + blocks.Add(block); |
667 | 673 | }
|
668 |
| - side_effects.Add(CollectSideEffectsOnPathsToDominatedBlock( |
669 |
| - dominator, block)); |
670 | 674 | }
|
| 675 | + if (blocks.is_empty()) break; |
| 676 | + dominated = blocks.RemoveLast(); |
671 | 677 | }
|
672 | 678 | return side_effects;
|
673 | 679 | }
|
|
0 commit comments