From 7b235d7c4fc143a9d6db0b7b5a84d50f48337f1a Mon Sep 17 00:00:00 2001 From: Chris Ewald Date: Sat, 1 Apr 2023 01:36:43 -0400 Subject: [PATCH 1/2] Add CustomEvent to EventListener See https://github.com/microsoft/TypeScript/issues/28357 --- inputfiles/addedTypes.jsonc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/inputfiles/addedTypes.jsonc b/inputfiles/addedTypes.jsonc index 6f0a502c8..26be5bb43 100644 --- a/inputfiles/addedTypes.jsonc +++ b/inputfiles/addedTypes.jsonc @@ -688,7 +688,7 @@ // emitter for this one case. "callable": { "overrideSignatures": [ - "(evt: Event): void" + "(evt: Event | CustomEvent): void" ] } } @@ -701,7 +701,7 @@ "method": { "handleEvent": { "overrideSignatures": [ - "handleEvent(object: Event): void" + "handleEvent(object: Event | CustomEvent): void" ] } } From 6067acc255bfde140dacf55e68e65210c277a0e0 Mon Sep 17 00:00:00 2001 From: Chris Ewald Date: Sat, 1 Apr 2023 13:32:07 -0400 Subject: [PATCH 2/2] Update relevant baselines. --- baselines/audioworklet.generated.d.ts | 4 ++-- baselines/dom.generated.d.ts | 4 ++-- baselines/serviceworker.generated.d.ts | 4 ++-- baselines/sharedworker.generated.d.ts | 4 ++-- baselines/webworker.generated.d.ts | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/baselines/audioworklet.generated.d.ts b/baselines/audioworklet.generated.d.ts index 24bc08131..0e43f95dd 100644 --- a/baselines/audioworklet.generated.d.ts +++ b/baselines/audioworklet.generated.d.ts @@ -558,11 +558,11 @@ declare var Event: { }; interface EventListener { - (evt: Event): void; + (evt: Event | CustomEvent): void; } interface EventListenerObject { - handleEvent(object: Event): void; + handleEvent(object: Event | CustomEvent): void; } /** diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 0535ea6e7..573b8ee8f 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -8060,11 +8060,11 @@ declare var EventCounts: { }; interface EventListener { - (evt: Event): void; + (evt: Event | CustomEvent): void; } interface EventListenerObject { - handleEvent(object: Event): void; + handleEvent(object: Event | CustomEvent): void; } interface EventSourceEventMap { diff --git a/baselines/serviceworker.generated.d.ts b/baselines/serviceworker.generated.d.ts index c9e599b32..213967064 100644 --- a/baselines/serviceworker.generated.d.ts +++ b/baselines/serviceworker.generated.d.ts @@ -2293,11 +2293,11 @@ declare var Event: { }; interface EventListener { - (evt: Event): void; + (evt: Event | CustomEvent): void; } interface EventListenerObject { - handleEvent(object: Event): void; + handleEvent(object: Event | CustomEvent): void; } interface EventSourceEventMap { diff --git a/baselines/sharedworker.generated.d.ts b/baselines/sharedworker.generated.d.ts index 2d2ac33ff..2ab3d799b 100644 --- a/baselines/sharedworker.generated.d.ts +++ b/baselines/sharedworker.generated.d.ts @@ -2220,11 +2220,11 @@ declare var Event: { }; interface EventListener { - (evt: Event): void; + (evt: Event | CustomEvent): void; } interface EventListenerObject { - handleEvent(object: Event): void; + handleEvent(object: Event | CustomEvent): void; } interface EventSourceEventMap { diff --git a/baselines/webworker.generated.d.ts b/baselines/webworker.generated.d.ts index c5092cdf4..5be8647f7 100644 --- a/baselines/webworker.generated.d.ts +++ b/baselines/webworker.generated.d.ts @@ -2494,11 +2494,11 @@ declare var Event: { }; interface EventListener { - (evt: Event): void; + (evt: Event | CustomEvent): void; } interface EventListenerObject { - handleEvent(object: Event): void; + handleEvent(object: Event | CustomEvent): void; } interface EventSourceEventMap {