Support completions that require changing from dot to bracket access

Author: Andy Hanson

src/compiler/diagnosticMessages.json

@@ -3890,5 +3890,9 @@
     "Install '{0}'": {
         "category": "Message",
         "code": 95014
+    },
+    "Use bracket notation instead of dot notation": {
+        "category": "Message",
+        "code": 95015
     }
 }

src/services/completions.ts

@@ -11,8 +11,14 @@
 ////    "\u0031\u0062": "invalid unicode identifer name (1b)"
 ////};
 ////
-////x./*a*/;
+////[|x./*a*/;|]
 ////x["/*b*/"];
 
-verify.completionsAt("a", ["bar", "break", "any", "$", "b"]);
-verify.completionsAt("b", ["foo ", "bar", "break", "any", "#", "$", "b", "\u0031\u0062"]);
+verify.completionsAt("b", ["foo ", "bar", "break", "any", "#", "$", "b", "1b"]);
+
+verify.completionsAt("a", ["foo ", "bar", "break", "any", "#", "$", "b", "1b"]);
+verify.applyCodeActionFromCompletion("a", {
+    name: "foo ",
+    description: "Use bracket notation instead of dot notation",
+    newRangeContent: 'x[""];',
+});

tests/cases/fourslash/completionListInvalidMemberNames.ts

@@ -1,10 +1,19 @@
 /// <reference path='fourslash.ts' />
 
-////enum Foo {
-////    X, Y, '☆'
+// TODO: we should probably support this like we do in completionListInvalidMemberNames.ts
+
+////declare var Symbol: SymbolConstructor;
+////interface SymbolConstructor {
+////    readonly hasInstance: symbol;
+////}
+////interface Function {
+////    [Symbol.hasInstance](value: any): boolean;
+////}
+////interface SomeInterface {
+////    (value: number): any;
 ////}
-////Foo./*a*/;
-////Foo["/*b*/"];
+////var _ : SomeInterface;
+////_./**/
 
-verify.completionsAt("a", ["X", "Y"]);
-verify.completionsAt("b", ["X", "Y", "☆"]);
+goTo.marker();
+verify.not.completionListContains("[Symbol.hasInstance]");

tests/cases/fourslash/completionListInvalidMemberNames2.ts

@@ -0,0 +1,11 @@
+/// <reference path='fourslash.ts' />
+
+////declare const x: { "foo ": "space in the name", };
+////[|x.fo/**/;|]
+
+verify.completionsAt("", ["foo "]);
+verify.applyCodeActionFromCompletion("", {
+    name: "foo ",
+    description: "Use bracket notation instead of dot notation",
+    newRangeContent: 'x["fo"];',
+});

tests/cases/fourslash/completionListInvalidMemberNames3.ts

@@ -11,7 +11,7 @@
 ////     /**
 ////      * @param {string} foo A value.
 ////      * @returns {number} Another value
-////      * @mytag 
+////      * @mytag
 ////      */
 ////     method4(foo: string) { return 3; }
 //// }