Skip to content

Commit 93a9e31

Browse files
author
Marco Rossignoli
committed
fix the baseline
1 parent 46b4ff0 commit 93a9e31

File tree

3 files changed

+21
-24
lines changed

3 files changed

+21
-24
lines changed

test/IntegrationTests/MSTest.Acceptance.IntegrationTests/SdkTests.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ await RetryHelper.RetryAsync(
375375
.PatchCodeWithReplace("$TestingPlatformDotnetTestSupport$", string.Empty)
376376
.PatchCodeWithReplace("$ExtraProperties$", """
377377
<PublishAot>true</PublishAot>
378-
<EnableMicrosoftTestingExtensionsCodeCoverage>false</EnableMicrosoftTestingExtensionsCodeCoverage>
378+
<EnableMicrosoftTestingExtensionsCodeCoverage>false</EnableMicrosoftTestingExtensionsCodeCoverage>
379379
""")
380380
.PatchCodeWithReplace("$Extensions$", string.Empty),
381381
addPublicFeeds: true);

test/IntegrationTests/MSTest.Acceptance.IntegrationTests/testsbaseline.txt

+3-1
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.Messages.V
7171
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.Invalid_TestingProfile_Name_Should_Fail(string, Microsoft.Testing.TestInfrastructure.BuildConfiguration) (multitfm,Debug)
7272
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.Invalid_TestingProfile_Name_Should_Fail(string, Microsoft.Testing.TestInfrastructure.BuildConfiguration) (multitfm,Release)
7373
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.NativeAot_Smoke_Test_On_Windows()
74+
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.RunTests_With_CentralPackageManagement_Standalone(string, Microsoft.Testing.TestInfrastructure.BuildConfiguration) (multitfm,Debug)
75+
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.RunTests_With_CentralPackageManagement_Standalone(string, Microsoft.Testing.TestInfrastructure.BuildConfiguration) (multitfm,Release)
7476
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.RunTests_With_MSTestRunner_DotnetTest(string, Microsoft.Testing.TestInfrastructure.BuildConfiguration) (multitfm,Debug)
7577
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.RunTests_With_MSTestRunner_DotnetTest(string, Microsoft.Testing.TestInfrastructure.BuildConfiguration) (multitfm,Release)
7678
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.RunTests_With_MSTestRunner_Standalone(string, Microsoft.Testing.TestInfrastructure.BuildConfiguration) (multitfm,Debug)
@@ -93,4 +95,4 @@ MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.R
9395
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.RunTests_With_MSTestRunner_Standalone_Selectively_Enabled_Extensions(string, Microsoft.Testing.TestInfrastructure.BuildConfiguration, string, string, string) (multitfm,Release,TrxReport)
9496
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.RunTests_With_VSTest(string, Microsoft.Testing.TestInfrastructure.BuildConfiguration) (multitfm,Debug)
9597
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.SdkTests.RunTests_With_VSTest(string, Microsoft.Testing.TestInfrastructure.BuildConfiguration) (multitfm,Release)
96-
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.ValueTaskTests.CanUseValueTaskForAllKnownLocations()
98+
MSTest.Acceptance.IntegrationTests.MSTest.Acceptance.IntegrationTests.ValueTaskTests.CanUseValueTaskForAllKnownLocations()

test/Utilities/Microsoft.Testing.TestInfrastructure/DotnetCli.cs

+17-22
Original file line numberDiff line numberDiff line change
@@ -92,17 +92,7 @@ public static async Task<DotnetMuxerResult> RunAsync(
9292

9393
if (DoNotRetry)
9494
{
95-
if (args.StartsWith("dotnet ", StringComparison.OrdinalIgnoreCase))
96-
{
97-
throw new InvalidOperationException("Command should not start with 'dotnet'");
98-
}
99-
100-
using var dotnet = new DotnetMuxer(environmentVariables);
101-
int exitCode = await dotnet.Args(args, workingDirectory, timeoutInSeconds);
102-
103-
return exitCode != 0 && failIfReturnValueIsNotZero
104-
? throw new InvalidOperationException($"Command 'dotnet {args}' failed.\n\nStandardOutput:\n{dotnet.StandardOutput}\nStandardError:\n{dotnet.StandardError}")
105-
: new DotnetMuxerResult(args, exitCode, dotnet.StandardOutput, dotnet.StandardOutputLines, dotnet.StandardError, dotnet.StandardErrorLines);
95+
return await CallTheMuxer(args, environmentVariables, workingDirectory, timeoutInSeconds, failIfReturnValueIsNotZero);
10696
}
10797
else
10898
{
@@ -112,17 +102,7 @@ public static async Task<DotnetMuxerResult> RunAsync(
112102
.WaitAndRetryAsync(delay)
113103
.ExecuteAsync(async () =>
114104
{
115-
if (args.StartsWith("dotnet ", StringComparison.OrdinalIgnoreCase))
116-
{
117-
throw new InvalidOperationException("Command should not start with 'dotnet'");
118-
}
119-
120-
using var dotnet = new DotnetMuxer(environmentVariables);
121-
int exitCode = await dotnet.Args(args, workingDirectory, timeoutInSeconds);
122-
123-
return exitCode != 0 && failIfReturnValueIsNotZero
124-
? throw new InvalidOperationException($"Command 'dotnet {args}' failed.\n\nStandardOutput:\n{dotnet.StandardOutput}\nStandardError:\n{dotnet.StandardError}")
125-
: new DotnetMuxerResult(args, exitCode, dotnet.StandardOutput, dotnet.StandardOutputLines, dotnet.StandardError, dotnet.StandardErrorLines);
105+
return await CallTheMuxer(args, environmentVariables, workingDirectory, timeoutInSeconds, failIfReturnValueIsNotZero);
126106
});
127107
}
128108
}
@@ -131,4 +111,19 @@ public static async Task<DotnetMuxerResult> RunAsync(
131111
s_maxOutstandingCommands_semaphore.Release();
132112
}
133113
}
114+
115+
private static async Task<DotnetMuxerResult> CallTheMuxer(string args, Dictionary<string, string> environmentVariables, string? workingDirectory, int timeoutInSeconds, bool failIfReturnValueIsNotZero)
116+
{
117+
if (args.StartsWith("dotnet ", StringComparison.OrdinalIgnoreCase))
118+
{
119+
throw new InvalidOperationException("Command should not start with 'dotnet'");
120+
}
121+
122+
using var dotnet = new DotnetMuxer(environmentVariables);
123+
int exitCode = await dotnet.Args(args, workingDirectory, timeoutInSeconds);
124+
125+
return exitCode != 0 && failIfReturnValueIsNotZero
126+
? throw new InvalidOperationException($"Command 'dotnet {args}' failed.\n\nStandardOutput:\n{dotnet.StandardOutput}\nStandardError:\n{dotnet.StandardError}")
127+
: new DotnetMuxerResult(args, exitCode, dotnet.StandardOutput, dotnet.StandardOutputLines, dotnet.StandardError, dotnet.StandardErrorLines);
128+
}
134129
}

0 commit comments

Comments
 (0)