Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing localization for --minimum-expected-tests #4123

Closed
Youssef1313 opened this issue Nov 22, 2024 · 1 comment · Fixed by #4125
Closed

Missing localization for --minimum-expected-tests #4123

Youssef1313 opened this issue Nov 22, 2024 · 1 comment · Fixed by #4125
Assignees
@Youssef1313
Labels
Area: Localization Area: MTP Belongs to the Microsoft.Testing.Platform core library In-PR
Milestone
MSTest 3.7 / Plat...

Comments

@Youssef1313
Copy link
Member

testfx/src/Platform/Microsoft.Testing.Platform/CommandLine/PlatformCommandLineProvider.cs

Line 44 in 5c829c1

private static readonly CommandLineOption MinimumExpectedTests = new(MinimumExpectedTestsOptionKey, "Specifies the minimum number of tests that are expected to run.", ArgumentArity.ZeroOrOne, false, isBuiltIn: true);

@Youssef1313 Youssef1313 added Area: Localization Area: MTP Belongs to the Microsoft.Testing.Platform core library labels Nov 22, 2024
@Evangelink
Copy link
Member

@Youssef1313 thanks for noticing! Could you please move that to a resx?

@Evangelink Evangelink added this to the MSTest 3.7 / Platform 1.5 milestone Nov 22, 2024
@Youssef1313 Youssef1313 mentioned this issue Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
Area: Localization Area: MTP Belongs to the Microsoft.Testing.Platform core library In-PR
Projects
None yet
Milestone
MSTest 3.7 / Platform 1.5
Development

Successfully merging a pull request may close this issue.

Ensure --minimum-expected-tests description is localized Youssef1313/testfx
2 participants
@Evangelink @Youssef1313