Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpptools-srv crashes sometimes during handle_initialize in uv_run on Linux with C_Cpp.intelliSenseCacheSize > 0 #12668

Closed
sean-mcmanus opened this issue Aug 30, 2024 · 4 comments
Closed

cpptools-srv crashes sometimes during handle_initialize in uv_run on Linux with C_Cpp.intelliSenseCacheSize > 0 #12668

sean-mcmanus opened this issue Aug 30, 2024 · 4 comments
Assignees
@sean-mcmanus
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service reliability
Milestone
1.24.1

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Aug 30, 2024 •
edited
Loading

In the same scenario on Mac, I'm seeing cpptools get stuck, but it might be the same root cause (otherwise, I'll create a new issue for that later). UPDATE: That "stuck" issue is fixed now and was unrelated.
@sean-mcmanus sean-mcmanus added this to the 1.22 milestone Aug 30, 2024
@sean-mcmanus sean-mcmanus self-assigned this Aug 30, 2024
@sean-mcmanus sean-mcmanus moved this to In progress in cpptools Aug 30, 2024
@sean-mcmanus
Copy link
Contributor Author

In certain cases (on certain machines), the crash is not rare, but repros 99.9% of the time.

@sean-mcmanus sean-mcmanus changed the title Rare cpptools-srv crash during handle_initialize in uv_run on Linux cpptools-srv crashes sometimes during handle_initialize in uv_run on Linux Sep 12, 2024
@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Sep 17, 2024 •
edited
Loading

Our repro case stopped reproing, but we're not sure if it's actually fixed or not.

@sean-mcmanus sean-mcmanus modified the milestones: 1.22, 1.23 Oct 3, 2024
@sean-mcmanus sean-mcmanus modified the milestones: 1.23, 1.23.1 Nov 6, 2024
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Nov 6, 2024
@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Nov 12, 2024 •
edited
Loading

@Colengms This seems to still repro (and at the same spot). But the report_intellisense_results crash got fixed.

@sean-mcmanus sean-mcmanus removed the fixed Check the Milestone for the release in which the fix is or will be available. label Nov 12, 2024
@sean-mcmanus sean-mcmanus removed their assignment Nov 12, 2024
@sean-mcmanus sean-mcmanus modified the milestones: 1.23.1, 1.24 Jan 29, 2025
@bobbrow bobbrow moved this from Done to In progress in cpptools Feb 4, 2025
@sean-mcmanus sean-mcmanus changed the title cpptools-srv crashes sometimes during handle_initialize in uv_run on Linux cpptools-srv crashes sometimes during handle_initialize in uv_run on Linux with C_Cpp.intelliSenseCacheSize > 0 Feb 6, 2025
@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Feb 6, 2025 •
edited
Loading

It's caused by an invalid mmap call, so setting "C_Cpp.intelliSenseCacheSize": 0 should be a workaround. Although this may also be possible if modules are enabled.

@sean-mcmanus sean-mcmanus modified the milestones: 1.24, 1.24.1 Feb 7, 2025
This was referenced Feb 7, 2025
Merged
Open
@sean-mcmanus sean-mcmanus moved this from In progress to Pull Request in cpptools Feb 12, 2025
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Feb 13, 2025
@sean-mcmanus sean-mcmanus moved this from Pull Request to Done in cpptools Feb 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sean-mcmanus sean-mcmanus

Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service reliability
Projects
cpptools
Status: Done
Milestone
1.24.1
Development

No branches or pull requests
1 participant
@sean-mcmanus