Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The cpptools process may deadlock on shutdown if a configuration provider is used #13218

Closed
sean-mcmanus opened this issue Jan 30, 2025 · 4 comments
Closed

The cpptools process may deadlock on shutdown if a configuration provider is used #13218

sean-mcmanus opened this issue Jan 30, 2025 · 4 comments
Assignees
@Colengms
Labels
bug Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. fixed Check the Milestone for the release in which the fix is or will be available. Language Service reliability
Milestone
1.24.0

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jan 30, 2025 •
edited
Loading

It repros with 1.22.11 and 1.23.5 (not sure about 1.21.x and earlier). I'm not sure how common it is.

cpptools_context::request_custom_configuration would be on a thread call stack.
@sean-mcmanus sean-mcmanus added bug Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. Language Service reliability labels Jan 30, 2025
@sean-mcmanus sean-mcmanus added this to the 1.24.0 milestone Jan 30, 2025
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jan 31, 2025
@sean-mcmanus sean-mcmanus moved this to Done in cpptools Jan 31, 2025
@heartacker
Copy link

@sean-mcmanus can not find the packaged vsix in github release
Unfortunately, vscode's plugin store web version does not have an entry point to download either

@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Feb 12, 2025 •
edited
Loading

@heartacker Yeah...I was wondering if there was anyone who wanted the .vsix to published on GitHub for pre-releases. Previously, we only did that for release vsix's (but the marketplace allowed downloads). I'll check if it's okay to start publishing the pre-release .vsix on GitHub (I should know by tomorrow).

@sean-mcmanus
Copy link
Contributor Author

@heartacker The release is now updated with the .vsix's: https://github.com/microsoft/vscode-cpptools/releases/tag/v1.24.0

@heartacker
Copy link

thank you,my dear bro

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Colengms Colengms

Labels
bug Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. fixed Check the Milestone for the release in which the fix is or will be available. Language Service reliability
Projects
cpptools
Status: Done
Milestone
1.24.0
Development

No branches or pull requests
3 participants
@heartacker @sean-mcmanus @Colengms