Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Pull Request widget doesn't respect keybinding "when" clause #6685

Open
snoozbuster opened this issue Mar 3, 2025 · 0 comments
Open

Comments

@snoozbuster
Copy link

Type: Bug

  1. Have a keybind with a when expression which is not supposed to trigger when an input element has focus, such as the following: !editorTextFocus && !inputFocus || editorTextFocus && vim.active && vim.mode == 'Normal'
  2. Place the cursor into the "title" or "comment" sections of the "Create" panel when making a pull request
  3. Press the keybind
  4. Observe that the keybind is triggered

I was unable to use the "View Context Keys" developer tool action to view the context keys that were set on this panel so as to update my when expression - it highlighted the panel but didn't change to a "+" to allow selection. Additionally, my normal vim input bindings do not function in these inputs, it would be great if that could be fully functional. I have "open file..." bound to the spacebar due to Vim, so it is not possible to write PR titles/descriptions at present.

Can't 100% confirm if this worked before. I've been only recently using the plugin and am not 100% certain I've actually updated the title/description in this widget before. I feel like I must have, though.

Extension version: 0.104.1
VS Code version: Code 1.97.2 (Universal) (e54c774e0add60467559eb0d1e229c6452cf8447, 2025-02-12T23:20:35.343Z)
OS version: Darwin arm64 24.3.0
Modes:

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
2e7ec940:31000449
pythontbext0:30879054
cppperfnew:31000557
dwnewjupytercf:31046870
nativerepl2:31139839
pythonrstrctxt:31112756
nativeloc1:31192215
iacca1:31171482
5fd0e150:31155592
dwcopilot:31170013
6074i472:31201624
dwoutputs:31242946
customenabled:31248079
9064b325:31222308
copilot_t_ci:31222730
jda6j935:31233686
copilothoveron:31248524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant