Skip to content

Commit a54bbbe

Browse files
authored
Add missing ReturnResponseUrl to WinGetUtilInterop manifest (#5035)
1 parent 4ad9e40 commit a54bbbe

File tree

6 files changed

+29
-18
lines changed

6 files changed

+29
-18
lines changed

src/WinGetUtilInterop.UnitTests/ManifestUnitTest/V1ManifestReadTest.cs

+4
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,8 @@ private void ValidateManifestFields(Manifest manifest, TestManifestVersion manif
264264

265265
Assert.True(manifest.DisplayInstallWarnings);
266266
Assert.True(manifest.DownloadCommandProhibited);
267+
268+
Assert.Equal("https://defaultReturnResponseUrl.com", manifest.ExpectedReturnCodes[0].ReturnResponseUrl);
267269
}
268270

269271
if (manifestVersion >= TestManifestVersion.V170)
@@ -373,6 +375,8 @@ private void ValidateManifestFields(Manifest manifest, TestManifestVersion manif
373375

374376
Assert.True(installer1.DisplayInstallWarnings);
375377
Assert.True(installer1.DownloadCommandProhibited);
378+
379+
Assert.Equal("https://returnResponseUrl.com", installer1.ExpectedReturnCodes[0].ReturnResponseUrl);
376380
}
377381

378382
if (manifestVersion >= TestManifestVersion.V170)

src/WinGetUtilInterop.UnitTests/TestCollateral/V1_1ManifestMerged.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ ExpectedReturnCodes:
3434
ReturnResponse: contactSupport
3535
- InstallerReturnCode: 3
3636
ReturnResponse: custom
37-
ReturnResponseUrl: https://defaultReturnResponseUrl.com
3837
FileExtensions:
3938
- appx
4039
- msix

src/WinGetUtilInterop.UnitTests/TestCollateral/V1_6ManifestMerged.yaml

+6-5
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,10 @@ Markets:
105105
- US
106106
ExpectedReturnCodes:
107107
- InstallerReturnCode: 2
108-
ReturnResponse: contactSupport
108+
ReturnResponse: contactSupport
109+
ReturnResponseUrl: https://defaultReturnResponseUrl.com
109110
- InstallerReturnCode: 3
110111
ReturnResponse: custom
111-
ReturnResponseUrl: https://defaultReturnResponseUrl.com
112112
UnsupportedArguments:
113113
- log
114114
NestedInstallerType: msi
@@ -225,8 +225,9 @@ Installers:
225225
ExcludedMarkets:
226226
- "US"
227227
ExpectedReturnCodes:
228-
- InstallerReturnCode: 2
229-
ReturnResponse: contactSupport
228+
- InstallerReturnCode: 2
229+
ReturnResponse: contactSupport
230+
ReturnResponseUrl: https://returnResponseUrl.com
230231
DownloadCommandProhibited: true
231232
InstallationMetadata:
232233
DefaultInstallLocation: "%ProgramFiles%\\TestApp"
@@ -242,4 +243,4 @@ Installers:
242243
InstallerType: exe
243244
ProductCode: '{Bar}'
244245
ManifestType: merged
245-
ManifestVersion: 1.6.0
246+
ManifestVersion: 1.6.0

src/WinGetUtilInterop.UnitTests/TestCollateral/V1_7ManifestMerged.yaml

+6-5
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,10 @@ Markets:
106106
- US
107107
ExpectedReturnCodes:
108108
- InstallerReturnCode: 2
109-
ReturnResponse: contactSupport
109+
ReturnResponse: contactSupport
110+
ReturnResponseUrl: https://defaultReturnResponseUrl.com
110111
- InstallerReturnCode: 3
111112
ReturnResponse: custom
112-
ReturnResponseUrl: https://defaultReturnResponseUrl.com
113113
UnsupportedArguments:
114114
- log
115115
NestedInstallerType: msi
@@ -228,8 +228,9 @@ Installers:
228228
ExcludedMarkets:
229229
- "US"
230230
ExpectedReturnCodes:
231-
- InstallerReturnCode: 2
232-
ReturnResponse: contactSupport
231+
- InstallerReturnCode: 2
232+
ReturnResponse: contactSupport
233+
ReturnResponseUrl: https://returnResponseUrl.com
233234
DownloadCommandProhibited: true
234235
RepairBehavior: modify
235236
InstallationMetadata:
@@ -246,4 +247,4 @@ Installers:
246247
InstallerType: exe
247248
ProductCode: '{Bar}'
248249
ManifestType: merged
249-
ManifestVersion: 1.7.0
250+
ManifestVersion: 1.7.0

src/WinGetUtilInterop.UnitTests/TestCollateral/V1_9ManifestMerged.yaml

+5-4
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,10 @@ Markets:
106106
- US
107107
ExpectedReturnCodes:
108108
- InstallerReturnCode: 2
109-
ReturnResponse: contactSupport
109+
ReturnResponse: contactSupport
110+
ReturnResponseUrl: https://defaultReturnResponseUrl.com
110111
- InstallerReturnCode: 3
111112
ReturnResponse: custom
112-
ReturnResponseUrl: https://defaultReturnResponseUrl.com
113113
UnsupportedArguments:
114114
- log
115115
NestedInstallerType: msi
@@ -229,8 +229,9 @@ Installers:
229229
ExcludedMarkets:
230230
- "US"
231231
ExpectedReturnCodes:
232-
- InstallerReturnCode: 2
233-
ReturnResponse: contactSupport
232+
- InstallerReturnCode: 2
233+
ReturnResponse: contactSupport
234+
ReturnResponseUrl: https://returnResponseUrl.com
234235
DownloadCommandProhibited: true
235236
ArchiveBinariesDependOnPath: false
236237
RepairBehavior: modify

src/WinGetUtilInterop/Manifest/V1/InstallerExpectedReturnCode.cs

+8-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// -----------------------------------------------------------------------------
1+
// -----------------------------------------------------------------------------
22
// <copyright file="InstallerExpectedReturnCode.cs" company="Microsoft Corporation">
33
// Copyright (c) Microsoft Corporation. Licensed under the MIT License.
44
// </copyright>
@@ -19,6 +19,11 @@ public class InstallerExpectedReturnCode
1919
/// <summary>
2020
/// Gets or sets the corresponding response category.
2121
/// </summary>
22-
public string ReturnResponse { get; set; }
22+
public string ReturnResponse { get; set; }
23+
24+
/// <summary>
25+
/// Gets or sets the corresponding response url.
26+
/// </summary>
27+
public string ReturnResponseUrl { get; set; }
2328
}
24-
}
29+
}

0 commit comments

Comments
 (0)