chore: use top level await for something

closes #1817

Author: mightyiam

Diff for: src/test/_util.ts

@@ -2,43 +2,25 @@ import exported from '../index.js'
 import { plugin as tseslintPlugin } from 'typescript-eslint'
 import { TSESLint } from '@typescript-eslint/utils'
 import semver from 'semver'
-import type { PackageJson } from 'type-fest'
 import { readPackageUp } from 'read-package-up'
 
-interface PkgDetails {
-  pkgPath: string
-  pkgJson: PackageJson
-  ourDeps: NonNullable<PackageJson['dependencies']>
-  ourPeerDeps: NonNullable<PackageJson['peerDependencies']>
-  ourDevDeps: NonNullable<PackageJson['devDependencies']>
+const readResult = await readPackageUp()
+if (readResult === undefined) {
+  throw new Error()
 }
-
-export const getPkgDetails = async (): Promise<PkgDetails> => {
-  const readResult = await readPackageUp()
-  if (readResult === undefined) {
-    throw new Error()
-  }
-  const ourPkg = readResult.packageJson
-  if (ourPkg.dependencies === undefined) {
-    throw new Error()
-  }
-  const ourDeps = ourPkg.dependencies
-  if (ourPkg.peerDependencies === undefined) {
-    throw new Error()
-  }
-  const ourPeerDeps = ourPkg.peerDependencies
-  if (ourPkg.devDependencies === undefined) {
-    throw new Error()
-  }
-  const ourDevDeps = ourPkg.devDependencies
-  return {
-    pkgJson: ourPkg,
-    pkgPath: readResult.path,
-    ourDeps,
-    ourPeerDeps,
-    ourDevDeps,
-  }
+const ourPkg = readResult.packageJson
+if (ourPkg.dependencies === undefined) {
+  throw new Error()
+}
+export const ourDeps = ourPkg.dependencies
+if (ourPkg.peerDependencies === undefined) {
+  throw new Error()
+}
+export const ourPeerDeps = ourPkg.peerDependencies
+if (ourPkg.devDependencies === undefined) {
+  throw new Error()
 }
+export const ourDevDeps = ourPkg.devDependencies
 
 export const isSingleCaretRange = (rangeStr: string): boolean => {
   const range = new semver.Range(rangeStr)

Diff for: src/test/compatibility.ts

@@ -3,7 +3,12 @@ import type { TSESLint } from '@typescript-eslint/utils'
 import { ESLint } from 'eslint_bottom'
 import exported from '../index.js'
 import semver from 'semver'
-import { extractVersionRange, getPkgDetails } from './_util.js'
+import {
+  extractVersionRange,
+  ourDeps,
+  ourDevDeps,
+  ourPeerDeps,
+} from './_util.js'
 import {
   parser as tseslintBottomParser,
   plugin as tseslintBottomPlugin,
@@ -13,8 +18,6 @@ import nBottomPlugin from 'eslint-plugin-n_bottom'
 import promiseBottomPlugin from 'eslint-plugin-promise_bottom'
 
 test('bottom dep version is minimum of dep range', async (t) => {
-  const { ourDeps, ourDevDeps, ourPeerDeps } = await getPkgDetails()
-
   const bottomDepsThatAreNotMinOfDepRange = [
     ['typescript-eslint', ourDeps] as const,
     ['eslint', ourPeerDeps] as const,
@@ -24,7 +27,6 @@ test('bottom dep version is minimum of dep range', async (t) => {
   ]
     .map(([depName, depCategory]) => {
       const bottomRange = ourDevDeps[`${depName}_bottom`]
-      if (bottomRange === undefined) throw new Error()
       const bottomVersion = extractVersionRange(bottomRange)
 
       const depRange = depCategory[depName]

Diff for: src/test/dependencies.ts

@@ -1,14 +1,14 @@
 import test from 'ava'
 import {
   extractVersionRange,
-  getPkgDetails,
   isPinnedRange,
   isSingleCaretRange,
+  ourDeps,
+  ourDevDeps,
+  ourPeerDeps,
 } from './_util.js'
 
 test('range types', async (t) => {
-  const { ourDeps, ourPeerDeps, ourDevDeps } = await getPkgDetails()
-
   const nonCompliantDepRanges = Object.entries({
     dep: ourDeps,
     peer: ourPeerDeps,

Diff for: src/test/misc.ts

@@ -1,6 +1,6 @@
 import test from 'ava'
 import exported from '../index.js'
-import { getPkgDetails } from './_util.js'
+import { ourDeps } from './_util.js'
 
 test('rule configs are arrays', (t) => {
   if (exported.rules === undefined) throw new Error()
@@ -11,10 +11,7 @@ test('rule configs are arrays', (t) => {
 })
 
 test('tseslint dep group same version', async (t) => {
-  const { ourDeps } = await getPkgDetails()
   const tseslint = ourDeps['typescript-eslint']
-  if (tseslint === undefined) throw new Error()
   const tseslintUtils = ourDeps['@typescript-eslint/utils']
-  if (tseslintUtils === undefined) throw new Error()
   t.is(tseslint, tseslintUtils)
 })