deps: add profiler log version test

431eb17 had integrated the addition of
V8's version in V8's profiler log files, without backporting the test
that was included in the original change
(https://codereview.chromium.org/806143002). This commit backports this
test.

The newly added test was tested with
nodejs#9208.

Author: Julien Gilli

deps/v8/src/log-utils.cc

@@ -54,7 +54,7 @@ void Log::Initialize(const char* log_file_name) {
 
   if (output_handle_ != NULL) {
     Log::MessageBuilder msg(this);
-    msg.Append("v8-version,%d,%d,%d,%d,%d\n", Version::GetMajor(),
+    msg.Append("v8-version,%d,%d,%d,%d,%d", Version::GetMajor(),
                Version::GetMinor(), Version::GetBuild(), Version::GetPatch(),
                Version::IsCandidate());
     msg.WriteToLogFile();

deps/v8/test/cctest/test-log.cc

@@ -496,20 +496,15 @@ TEST(EquivalenceOfLoggingAndTraversal) {
 }
 
 TEST(LogVersion) {
-  v8::Isolate* isolate;
-  {
-    ScopedLoggerInitializer initialize_logger;
-    isolate = initialize_logger.isolate();
-    bool exists = false;
-    i::Vector<const char> log(
-        i::ReadFile(initialize_logger.StopLoggingGetTempFile(), &exists, true));
-    CHECK(exists);
-    i::EmbeddedVector<char, 100> ref_data;
-    i::SNPrintF(ref_data, "v8-version,%d,%d,%d,%d,%d", i::Version::GetMajor(),
-                i::Version::GetMinor(), i::Version::GetBuild(),
-                i::Version::GetPatch(), i::Version::IsCandidate());
-    CHECK_NE(NULL, StrNStr(log.start(), ref_data.start(), log.length()));
-    log.Dispose();
-  }
-  isolate->Dispose();
+  ScopedLoggerInitializer initialize_logger;
+  bool exists = false;
+  i::Vector<const char> log(
+      i::ReadFile(initialize_logger.StopLoggingGetTempFile(), &exists, true));
+  CHECK(exists);
+  i::EmbeddedVector<char, 100> ref_data;
+  i::SNPrintF(ref_data, "v8-version,%d,%d,%d,%d,%d", i::Version::GetMajor(),
+              i::Version::GetMinor(), i::Version::GetBuild(),
+              i::Version::GetPatch(), i::Version::IsCandidate());
+  CHECK_NE(NULL, StrNStr(log.start(), ref_data.start(), log.length()));
+  log.Dispose();
 }