Skip to content

Commit e8d0850

Browse files
committedJan 19, 2015
win: bring back xp/2k3 support
Chrome still runs on Windows XP, so there is no reason that iojs couldn't. PR: nodejs/node#512 Reviewed-by: Ben Noordhuis <[email protected]>
1 parent 4dd22b9 commit e8d0850

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed
 

‎common.gypi

+14-6
Original file line numberDiff line numberDiff line change
@@ -141,20 +141,28 @@
141141
},
142142
'VCLinkerTool': {
143143
'conditions': [
144+
['target_arch=="ia32"', {
145+
'TargetMachine' : 1, # /MACHINE:X86
146+
'target_conditions': [
147+
['_type=="executable"', {
148+
'AdditionalOptions': [ '/SubSystem:Console,"5.01"' ],
149+
}],
150+
],
151+
}],
144152
['target_arch=="x64"', {
145-
'TargetMachine' : 17 # /MACHINE:X64
153+
'TargetMachine' : 17, # /MACHINE:AMD64
154+
'target_conditions': [
155+
['_type=="executable"', {
156+
'AdditionalOptions': [ '/SubSystem:Console,"5.02"' ],
157+
}],
158+
],
146159
}],
147160
],
148161
'GenerateDebugInformation': 'true',
149162
'RandomizedBaseAddress': 2, # enable ASLR
150163
'DataExecutionPrevention': 2, # enable DEP
151164
'AllowIsolation': 'true',
152165
'SuppressStartupBanner': 'true',
153-
'target_conditions': [
154-
['_type=="executable"', {
155-
'SubSystem': 1, # console executable
156-
}],
157-
],
158166
},
159167
},
160168
'msvs_disabled_warnings': [4351, 4355, 4800],

‎node.gyp

-3
Original file line numberDiff line numberDiff line change
@@ -378,9 +378,6 @@
378378
}],
379379
],
380380
'msvs_settings': {
381-
'VCLinkerTool': {
382-
'SubSystem': 1, # /subsystem:console
383-
},
384381
'VCManifestTool': {
385382
'EmbedManifest': 'true',
386383
'AdditionalManifestFiles': 'src/res/node.exe.extra.manifest'

0 commit comments

Comments
 (0)