Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop Node v12 support because of the EOL #77

Merged
merged 4 commits into from
Oct 2, 2022
Merged

chore: drop Node v12 support because of the EOL #77

merged 4 commits into from
Oct 2, 2022

Conversation

tasshi-me
Copy link
Contributor

@tasshi-me tasshi-me commented Sep 27, 2022 •
edited
Loading

Why

Because Node v12 has been in EOL since April 30th.
CI/CD workflows failed because of using Node v12 which setup-node stopped supporting.

What

  • drop Node v12 from the engines of package.json.
    • from this PR, the oldest supported version is v14.
  • update Node version in CI ( [12, 14] -> [14, 16])

Also, I updated following actions

  • actions/checkout: v2.3.1->v3.0.2
  • actions/setup-node v2.0.0->v3.4.1

How to test

npm ci

npm run lint
npm run test

@tasshi-me tasshi-me marked this pull request as ready for review September 27, 2022 01:05
miyajan
miyajan approved these changes Oct 2, 2022
View reviewed changes
Copy link
Owner

@miyajan miyajan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉

@miyajan miyajan merged commit 25357c8 into miyajan:master Oct 2, 2022
@tasshi-me tasshi-me deleted the chore/drop-supporting-node-12 branch October 3, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miyajan miyajan miyajan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tasshi-me @miyajan