fix(NODE-2129): fix sporadic AcquireCredentialsHandle error #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a sporadic error that occurred when calling the
AcquireCredentialsHandleW
SSPI function. This was caused by uninitialized struct members. TheauthIdentity
variable was allocated on the stack but not initialized. Depending on the stack's state, that caused theauthIdentity.DomainLength
or potentially theauthIdentity.Domain
members to have unpredictable content. Ensuring proper nulled initialization fixes this.This PR also includes a fix for a memory leak in the
to_wstring
function. The allocatedoutput
array was neverdelete
ed.We tested this fix as part of
mongosh
in a Windows environment with Kerberos.@addaleax 🙇